Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused canLoadFile function from HermesExecutor.java #39481

Closed
wants to merge 1 commit into from
Closed

Remove unused canLoadFile function from HermesExecutor.java #39481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ...t-native/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/HermesExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,6 @@ public String getName() {
return "HermesExecutor" + mode_;
}

/**
* Return whether this class can load a file at the given path, based on a binary compatibility
* check between the contents of the file and the Hermes VM.
*
* @param path the path containing the file to inspect.
* @return whether the given file is compatible with the Hermes VM.
*/
public static native boolean canLoadFile(String path);

private static native HybridData initHybridDefaultConfig(
boolean enableDebugger, String debuggerName);

Expand Down
7 changes: 1 addition & 6 deletions packages/react-native/ReactAndroid/src/main/jni/react/hermes/reactexecutor/OnLoad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,12 @@ class HermesExecutorHolder
return makeCxxInstance(std::move(factory));
}

static bool canLoadFile(jni::alias_ref<jclass>, const std::string& path) {
return true;
}

static void registerNatives() {
registerHybrid(
{makeNativeMethod("initHybrid", HermesExecutorHolder::initHybrid),
makeNativeMethod(
"initHybridDefaultConfig",
HermesExecutorHolder::initHybridDefaultConfig),
makeNativeMethod("canLoadFile", HermesExecutorHolder::canLoadFile)});
HermesExecutorHolder::initHybridDefaultConfig)});
}

private:
Expand Down