Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Android API < 23 in ReactEditText #39671

Closed
wants to merge 6 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 26, 2023

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: d4791f3bed87059ef6758254d0a1b522f373e2e0
@analysis-bot
Copy link

analysis-bot commented Sep 26, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,902,915 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,381,659 +12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5be6f49
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: a00b8db730ce5b0d0bea283f2fb28ab24a029581
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: d7bfe00a76aa03802be6c103b90fae0c3d1459e2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: 367106b7ca6c2c5b9340eeb9e43921e16f640147
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: 68d204aa408866dffda78289aa72d68f4c029899
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: 2dc81dca23dfc175343731a09413a8a8e40219a4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: a979cf7c924a630a2c4542d6f116a3a34cdd2ccc
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 5dc210f

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: dd03a6316e96f58162edeb733536eefecef3f832
mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 29, 2023
Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: 99e77ca7cf237dc35ac4b80928bed1f94363392f
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextShadowNode

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextShadowNode

Differential Revision: D48545511

fbshipit-source-id: 35b88107822e5b76e8d010bf16c13adb969210a7
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextView

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextView

Differential Revision: D48545504

fbshipit-source-id: a461353e57550847e65fedd3f2db49d5cb89bfa6
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextAttributeProps

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextAttributeProps

Differential Revision: D48545514

fbshipit-source-id: 2307263ca09c2be10df3e0393402b1bed66bea73
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Differential Revision: D48545502

fbshipit-source-id: ccc496bb0af0aa85c2cb687e5199a1a728358f79
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManagerMapBuffer

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManagerMapBuffer

Differential Revision: D48545518

fbshipit-source-id: 7e18f547773293c56cbf0cdc1fc5154d1e44f121
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545507

Summary:
Pull Request resolved: facebook#39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: 76f7f1c9038e6062be9683b0f9a961b8cbbf184b
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1904e80.

lunaleaps pushed a commit that referenced this pull request Nov 17, 2023
Summary:
Pull Request resolved: #39671

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Reviewed By: NickGerleman

Differential Revision: D48545507

fbshipit-source-id: 98be52ba36248962864e99e80ff648bbb351ff61
huntie added a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants