Fix Glog for earlier versions of Xcode #41058

cipolleschi · 2023-10-18T14:20:02Z

Summary:
Glog has a piece of code which looks like this:

namespace google {

// They need the definitions of integer types.
#include "glog/log_severity.h"
#include "glog/vlog_is_on.h"

This fragment is:

Always valid when the pod does not define a module
Valid for Xcode >= 14.3, when the pod do define a module
Invalid for Xcode < 14.3, when the pod do define a module

Modules are required to support Swift, so, in the long run, we want to have DEFINES_MODULE set to YES for Glog.

This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store.
Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024.

Changelog:

[Internal] - Make Glog work with older versions of Xcode

Differential Revision: D50410487

facebook-github-bot · 2023-10-18T14:20:12Z

This pull request was exported from Phabricator. Differential Revision: D50410487

tido64 · 2023-10-18T14:29:29Z

packages/react-native/third-party-podspecs/glog.podspec

+
+  # TODO: T167482718 Remove this code after April 2024, when Apple will
+  # push the lower version of Xcode required to upload apps to the Store.
+  xcode_path = `xcode-select -p` # This return the current version of Xcode


This makes the assumption that Xcode was installed as /Applications/Xcode-15.0.0.app/Contents/Developer etc. It's common for this command to return /Applications/Xcode.app/Contents/Developer without a version number.

Maybe try xcodebuild -version instead?

% xcodebuild -version Xcode 15.0 Build version 15A240d

Well spotted, I updated the PR using xcodebuild -version which is the same logic we used for the Xcode 15 flag workaround and it should be more robust.

Summary: Glog has a piece of code which looks like this: ``` namespace google { // They need the definitions of integer types. #include "glog/log_severity.h" #include "glog/vlog_is_on.h" ``` This fragment is: - Always valid when the pod does not define a module - Valid for Xcode >= 14.3, when the pod do define a module - Invalid for Xcode < 14.3, when the pod do define a module Modules are required to support Swift, so, in the long run, we want to have `DEFINES_MODULE` set to `YES` for `Glog`. This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store. Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024. ## Changelog: [Internal] - Make Glog work with older versions of Xcode Differential Revision: D50410487

facebook-github-bot · 2023-10-18T14:42:42Z

This pull request was exported from Phabricator. Differential Revision: D50410487

facebook-github-bot · 2023-10-18T14:42:43Z

This pull request was exported from Phabricator. Differential Revision: D50410487

Summary: Glog has a piece of code which looks like this: ``` namespace google { // They need the definitions of integer types. #include "glog/log_severity.h" #include "glog/vlog_is_on.h" ``` This fragment is: - Always valid when the pod does not define a module - Valid for Xcode >= 14.3, when the pod do define a module - Invalid for Xcode < 14.3, when the pod do define a module Modules are required to support Swift, so, in the long run, we want to have `DEFINES_MODULE` set to `YES` for `Glog`. This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store. Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024. ## Changelog: [Internal] - Make Glog work with older versions of Xcode Reviewed By: cortinico Differential Revision: D50410487

facebook-github-bot · 2023-10-18T15:09:05Z

This pull request was exported from Phabricator. Differential Revision: D50410487

github-actions · 2023-10-18T15:51:17Z

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 620306f

tido64 · 2023-10-18T16:12:07Z

packages/react-native/third-party-podspecs/glog.podspec

+
+  # TODO: T167482718 Remove this code after April 2024, when Apple will
+  # push the lower version of Xcode required to upload apps to the Store.
+  xcode_path = `xcodebuild -version` # This return the current version of Xcode


Nit: Should this be renamed output or something?

tido64 · 2023-10-18T16:12:22Z

packages/react-native/third-party-podspecs/glog.podspec

+  minor_version = match[2].to_i
+  is_greater_than_15 = major_version >= 15
+  is_greater_than_14_3 = major_version == 14 && minor_version >= 3
+  should_define_modules = is_greater_than_15 ? "YES" : is_greater_than_14_3 ? "YES" : "NO"


Nit:

Suggested change

should_define_modules = is_greater_than_15 ? "YES" : is_greater_than_14_3 ? "YES" : "NO"

should_define_modules = is_greater_than_15 || is_greater_than_14_3 ? "YES" : "NO"

facebook-github-bot · 2023-10-18T18:41:16Z

This pull request has been merged in 1e5e3b5.

Summary: Pull Request resolved: #41058 Glog has a piece of code which looks like this: ``` namespace google { // They need the definitions of integer types. #include "glog/log_severity.h" #include "glog/vlog_is_on.h" ``` This fragment is: - Always valid when the pod does not define a module - Valid for Xcode >= 14.3, when the pod do define a module - Invalid for Xcode < 14.3, when the pod do define a module Modules are required to support Swift, so, in the long run, we want to have `DEFINES_MODULE` set to `YES` for `Glog`. This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store. Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024. ## Changelog: [Internal] - Make Glog work with older versions of Xcode Reviewed By: cortinico Differential Revision: D50410487 fbshipit-source-id: 96145cdf9ba1bc75622403d3c06454d6d4bfd967

Summary: Pull Request resolved: facebook/react-native#41058 Glog has a piece of code which looks like this: ``` namespace google { // They need the definitions of integer types. #include "glog/log_severity.h" #include "glog/vlog_is_on.h" ``` This fragment is: - Always valid when the pod does not define a module - Valid for Xcode >= 14.3, when the pod do define a module - Invalid for Xcode < 14.3, when the pod do define a module Modules are required to support Swift, so, in the long run, we want to have `DEFINES_MODULE` set to `YES` for `Glog`. This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store. Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024. ## Changelog: [Internal] - Make Glog work with older versions of Xcode Reviewed By: cortinico Differential Revision: D50410487 fbshipit-source-id: 96145cdf9ba1bc75622403d3c06454d6d4bfd967

Summary: Pull Request resolved: facebook#41058 Glog has a piece of code which looks like this: ``` namespace google { // They need the definitions of integer types. #include "glog/log_severity.h" #include "glog/vlog_is_on.h" ``` This fragment is: - Always valid when the pod does not define a module - Valid for Xcode >= 14.3, when the pod do define a module - Invalid for Xcode < 14.3, when the pod do define a module Modules are required to support Swift, so, in the long run, we want to have `DEFINES_MODULE` set to `YES` for `Glog`. This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store. Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024. ## Changelog: [Internal] - Make Glog work with older versions of Xcode Reviewed By: cortinico Differential Revision: D50410487 fbshipit-source-id: 96145cdf9ba1bc75622403d3c06454d6d4bfd967

* Set Hermes release version * bumped packages versions #publish-packages-to-npm * Bump react-native-babel-preset to 0.73.18 #publish-packages-to-npm * Enable native view configs in bridgeless mode in OSS (facebook#39476) Summary: Pull Request resolved: facebook#39476 This diff enables native view config interop layer in bridgeless mode by default for OSS. It also removes redundant `enableNativeViewConfigsInBridgelessMode` JS feature flag. Changelog: [General][Added] - Native view config interop layer enabled in bridgeless mode. Reviewed By: luluwu2032 Differential Revision: D49318325 fbshipit-source-id: ea2e38b2ea10637b578d98e38d97eed923498fb3 * Enable Template with Bridgeless (facebook#39661) Summary: Pull Request resolved: facebook#39661 Changelog: [Android][Changed] - Enable Template with Bridgeless Reviewed By: cortinico Differential Revision: D49464580 fbshipit-source-id: 26dd8e2a0b9a66421d58f147eed4d2fd28817dc7 * [Hotfix] Remove node engines constraint for normalize-color (facebook#39698) * Bump CLI to 12.0.0-alpha.16 * bumped packages versions #publish-packages-to-npm * Reduce visibility of functions in ReactHostImpl (facebook#39640) Summary: Pull Request resolved: facebook#39640 changelog: [internal] internal Reducing visibility from public to package only for `ReactHostImpl.getDefaultHardwareBackBtnHandler()` since it's only used within package Reviewed By: mdvacca Differential Revision: D49612859 fbshipit-source-id: 3c40888da732f33dc046d9363b08119e707f4ea4 * Enable TurboModule interop in Bridgeless Mode (facebook#39687) Summary: Pull Request resolved: facebook#39687 Bridgeless mode is releasing in 0.73. Bridgeless mode isn't stable inside RNTester (in 0.73) without the TurboModule interop layer: T164853040. **Changes:** Enable the TurboModule interop layer in RNTester (Bridgeless Mode). **Urgency:** This will unblock the 0.73. Changelog: [General][Added] - Enable TurboModule interop in Bridgeless mode Reviewed By: fkgozali, dmytrorykun, luluwu2032 Differential Revision: D49653919 fbshipit-source-id: a4a09a99544c2ef8713484dbeab5cb04f29256cc * Export Commands and Constants only if native view config interop is enabled (facebook#39696) Summary: Pull Request resolved: facebook#39696 `Commands` and `Constants` should be set in native only if component data is instantiated via native view config interop layer. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D49684166 fbshipit-source-id: ceaa29c2ed3336aa6e21a116a3f5f94e03c225c1 * Bump CLI to 12.0.0-alpha.17 * Bump package versions #publish-packages-to-npm * Update Xcode 15 patches to be more robust (facebook#39710) Summary: Pull Request resolved: facebook#39710 Last week Apple released Xcode 15, which required us to ship a workaround for the new linker. Unfortunately, the previous fix was not good enough and there were some edge cases that were not covered. For example, in some occasions the flags are read as an array and the `-Wl` and the `-ld_classic` flags were separated and not properly removed when moving from Xcode 15 to Xcpde 14.3.1. This change fixes those edge cases, with a more robust solution where: - We convert the flags to a string. - We trim the string and the values properly. - We add the flags when running `pod install` with Xcode 15 as the default iOS toolchain. - We remove the flags when running `pod install` with Xcode <15 as the default iOS toolchain. ## Changelog: [Internal] - Make the Xcode 15 workaround more robust. Reviewed By: dmytrorykun Differential Revision: D49748844 fbshipit-source-id: 34976d148f123c5aacba6487a500874bb938fe99 * Sync debugger-frontend Summary: Sync latest `debugger-frontend` artifacts, based on motiz88/rn-chrome-devtools-frontend#12. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D49502838 fbshipit-source-id: 25805066670ac35ec976dc820a73a722ee182dd2 * Mark initHybrid as @JvmStatic (facebook#39755) Summary: Pull Request resolved: facebook#39755 The goal of this diff is to fix: ``` JNI DETECTED ERROR IN APPLICATION: JNI NewGlobalRef called with pending exception java.lang.NoSuchMethodError: no static or non-static method "Lcom/facebook/react/jscexecutor/JSCExecutor;.initHybrid(Lcom/facebook/react/bridge/ReadableNativeMap;)Lcom/facebook/jni/HybridData;" ``` changelog: [internal] internal Reviewed By: luluwu2032 Differential Revision: D49831595 fbshipit-source-id: 9ce22cdccdd02af74edb27be2df72a469d3166c9 * Bump package versions #publish-packages-to-npm * Bump package versions (dependant packages) #publish-packages-to-npm * [0.73.0-rc.0] Bump version numbers * Fix typings for ReactNativeVersion.js This is an eager cherry pick of facebook#39784 for `0.73-stable`. * Revert "[0.73.0-rc.0] Bump version numbers" This reverts commit 6b9cf50. * [RN][CI] Make the Choose CI Job run also on tags (facebook#39774) * [0.73.0-rc.0] Bump version numbers * Revert "Fix typings for ReactNativeVersion.js" This reverts commit b6c0703. * Fix typings for ReactNativeVersionCheck Applies correct fix for `_formatVersion` misalignment — based on facebook#36657. * Fix start command exit behaviour This is an eager cherry pick of facebook#39788 for `0.73-stable`. * Bump package versions #publish-packages-to-npm * [0.73.0-rc.1] Bump version numbers * Revert "[0.73.0-rc.1] Bump version numbers" This reverts commit 725b1c9. * Make jobs required for hermes to run on tagged builds (facebook#39800) * [0.73.0-rc.1] Bump version numbers * Fix broken Loading/Refreshing indicator on Android Summary: The Loading.../Refreshing... indicator is currently broken on Android. The reason is related to D42599220 We used to have a Toast shown to users on Android as a fallback, but as the DevLoadingView is not always loaded as a module in the core package, this ends up in the banner never beign shown to the user (on RN Tester or template apps). Changelog: [Android] [Fixed] - Fix broken Loading/Refreshing indicator on Android Reviewed By: cipolleschi Differential Revision: D49876757 fbshipit-source-id: 400e002327ebca908e3e7a7f81c5066888ac4e9b * Remove unneeded write to .version file (facebook#39807) Summary: Pull Request resolved: facebook#39807 We used to need this file so that we could read the react native version when [creating Hermes artifacts](facebook@e4b5d3e#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R1507). Originally, that change was introduced [here](facebook@e4b5d3e#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47) Despite the fact that that approach was wrong, as we already have the right version in the package.json which is guaranteed to be present, a lot has changed since then and we don't need that file anymore. ## Changelog: [Internal] - Remove lines that write a .version file while releasing on npm Reviewed By: lunaleaps Differential Revision: D49909718 fbshipit-source-id: bd23d6d73001d0b58bf6b0321ed6d4ceb3523e7a * Default to native view configs in bridged mode and to static view configs in bridgeless mode (facebook#39704) Summary: Pull Request resolved: facebook#39704 Default to native view configs in bridged mode and to static view configs in bridgeless mode. Remove `setRuntimeConfigProvider` calls from RNTester and from the Template. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D49687252 fbshipit-source-id: 140e1c510ba3fbc153978b59c8bb4b4e35bc7571 * Fix Gemfile, setting Active support to < 7.1.0 (facebook#39828) Summary: Pull Request resolved: facebook#39828 Active Suppert released a new Gem which is incompatible with Cocoapods 1.13.0, the latest release, as they removed a method used by cocoapods. This fix ensures that we install compatible versions of the Gem. ## Changelog: [iOS][Fixed] - Set the max version of Active support to 7.0.8 Reviewed By: hoxyq Differential Revision: D49949782 fbshipit-source-id: 278097502d3a416567cc8c0b90090fee4fb21503 * fix: view flips on RTL with new transform origin changes in Paper arch. (facebook#39803) Summary: Fixes - facebook#38626 (comment). Explained the issue [here](facebook#38626 (comment)). ## Changelog: [IOS] [FIXED] - View flips horizontally in paper arch on RTL Pull Request resolved: facebook#39803 Test Plan: Run RNTester in Paper mode on iOS Reviewed By: NickGerleman Differential Revision: D49952227 Pulled By: lunaleaps fbshipit-source-id: 7240552e499765859dceea0a0406561cc3a3148f * [iOS] Deprecate RCTGetMultiplierForContentSizeCategory (facebook#39785) * Set hermes for Android template project in testing Summary: Changelog: [Internal] - Set the hermes value as specified by the test-e2e-local script flag. Right now, the script incorrectly ignores the flag By default, the template project has `hermesEnabled=true` Reviewed By: cipolleschi Differential Revision: D49831355 fbshipit-source-id: 7fb8613fa86f2c6140b7d25b16aeb583e6e26c12 * fix missing sed import * Update pod for CI * Update .gitignore for sdks/downloads * [0.73.0-rc.2] Bump version numbers * Add --experimental-debugger-frontend flag, restore 0.72 flow as base (facebook#40766) Summary: Pull Request resolved: facebook#40766 This changeset allows users to opt into the new debugger frontend experience by passing `--experimental-debugger` to `react-native start`. **We are defaulting this option to `true`** for now, but will continue to evaluate this feature before 0.73 ships. It restores Flipper (via `flipper://`) as the default handling for `/open-debugger` (matching 0.72 behaviour) when this flag is not enabled. Detailed changes: - Replaces `enableCustomDebuggerFrontend` experiment in `dev-middleware` with `enableNewDebugger`. The latter now hard-swaps between the Flipper and new launch flows. - Removes now-unused switching of `devtoolsFrontendUrl`. - Implements `deprecated_openFlipperMiddleware` (matching previous RN CLI implementation). - Disables "`j` to debug" key handler by default. - Marks "`j` to debug" and `/open-debugger` console logs as experimental. Changelog: [Changed][General] Gate new debugger frontend behind `--experimental-debugger` flag, restore Flipper as base launch flow Reviewed By: motiz88 Differential Revision: D50084590 fbshipit-source-id: 5234634f20110cb7933b1787bd2c86f645411fff * [0.73] Make sure template is consuming the right buildToolsVersion (facebook#39957) * Store hermes stable artifacts inside Pods directory (facebook#40733) Summary: Pull Request resolved: facebook#40733 Node package managers may purge or recreate `node_modules/react-native` when adding/removenf project dependencies. Storing hermes iOS artifacts inside `node_modules/react-native/sdks` is not reliable. This diff moves those artifacts to `Pods/hermes-engine-artifacts`. Should fix facebook#39903 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D50081559 fbshipit-source-id: a130898e12fb6275cadaef7617bf4b6a09e6487e * Top-down onLayout events (facebook#39644) Summary: Pull Request resolved: facebook#39644 This makes Android Paper/Classic renderer fire `onLayout` events top down, like in Fabric/new Architecture. This gives a much more sane model for using layout events to calculate bottom/right-edge insets. I was under the impression that Paper in general was bottom-up, but it turns out that is only true for Android and Windows (iOS seems totally deterministic). This is a behavior change, but to my knowledge was never hit during the Fabric migration, and any JS code already written for both Android and iOS cannot make assumptions here anyways. Changelog: [General][Changed] - Make layout events top-down on Android classic renderer Reviewed By: mdvacca Differential Revision: D49627996 fbshipit-source-id: 29964b421dd420681d45348c7db16f211a6c087f * Deterministic onLayout event ordering for iOS Paper (facebook#40748) Summary: Pull Request resolved: facebook#40748 The ordering of `onLayout` events is non-deterministic on iOS Paper, due to nodes being added to an `NSHashTable` before iteration, instead of an ordered collection. We don't do any lookups on the collection, so I think this was chosen over `NSMutableArray` for the sake of `[NSHashTable weakObjectsHashTable]`, to avoid retain/release. Using a collection which does retain/release seems to cause a crash due to double release or similar, so those semantics seem intentional (though I'm not super familiar with the model here). We can replicate the memory semantics with ordering by using `NSPointerArray` (which is unfortunately not parameterized). This change does that, so we get consistently top-down layout events (matching Fabric, and Android Paper as of D49627996). This lets us use multiple layout events to calculate right/bottom edge insets deterministically. Changelog: [iOS][Changed] - Deterministic onLayout event ordering for iOS Paper Reviewed By: luluwu2032 Differential Revision: D50093411 fbshipit-source-id: f6a9d5c973b97aede879baa8b952cc1be2447f28 * Remove code to support bottom-up layout events in horizontal RTL (facebook#39646) Summary: Pull Request resolved: facebook#39646 We can dramatically simplify this code and remove quirks/hacks, now that we can assume layout events are always fired top down. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D49628669 fbshipit-source-id: 7de5bbc4597eba1c59aaa7672c70e76d2786c7ef * Fix iOS Paper Scroll Event RTL check (facebook#40751) Summary: Pull Request resolved: facebook#40751 In D48379915 I fixed inverted `contentOffset` in `onScroll` events on iOS. I thought I tested on Paper, but I think this was during a period where the Paper route in Catalyst was actually launching Fabric (oops). In Paper, at least under `forceRTL` and English, `[UIApplication sharedApplication].userInterfaceLayoutDirection` is not set to RTL. We instead have a per-view `reactLayoutDirection` we should be reading. This sort of thing isn't currently set on Fabric, which checks application-level RTL. This seems... not right with being able to set `direction` in a subtree context, but Android does the same thing, and that would take some greater changes. Changelog: [iOS][Fixed] - Fix iOS Paper Scroll Event RTL check Reviewed By: luluwu2032 Differential Revision: D50098310 fbshipit-source-id: e321fca7b2f7983e903e23237bc2d604c72f98a3 * Disable --experimental-debugger by default (facebook#40795) Summary: Pull Request resolved: facebook#40795 Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D50178494 fbshipit-source-id: b833b6accadd2902d97a45e030cd48d1b62ac438 * make runtime reference thread safe on tickleJs call Summary: The reference to runtime assumes the queue will ensure references to runtime are valid when invoked. This isn't the case if you create a breakpoint, Hermes hit that breakpoint and your refresh the app. This consistently will crash the app. The fix is to not assument this, similar to ReactCommon/react/runtime/hermes/HermesInstance.cpp Reviewed By: javache Differential Revision: D50225678 fbshipit-source-id: b45cae1f5f687bc8c699fd74b187376a547012c5 * Run all the tests when not on a PR Summary: ## Changelog: [Internal] - Run all the tests in CI when not on a PR Reviewed By: cortinico Differential Revision: D50220596 fbshipit-source-id: be1a30d713e9d427858cf22bd3ca9549ad513057 * Add "Hermes only" to open debugger key prompt Summary: Changelog: [Internal] Reviewed By: cortinico Differential Revision: D50327180 fbshipit-source-id: 6ee08fadd313828ddbc7702d5b3b1174a91b1ac1 * Refactors InspectorProxy to compare pathname portion of url passed in… (facebook#41005) Summary: … request to local pathname comparator variables to fix issue with other rightward elements of url such as query or fragment entering the comparison and causing 404 errors for key debugging routes. A change in Chromium appended the query "?for_tabs" to the /json/list request made by Chrome DevTools to find remote debugger targets. The current comparison in InspectorProxy.js compares the entire node IncomingMessage url field to the local pathname constants. The issue arises as url can also contain the query and fragment portions so the original comparison of "/json/list" === "/json/list" which resolved as true would become "/json/list?for_tabs" === "/json/list" and evaluate to false ultimately resulting in a 404 for the request. In summary, all these changes/issues caused remote debugging of Hermes code in React Native apps to become unavailable, greatly impacting developer experience. ## Changelog: [GENERAL] [FIXED] JS Debugging: Fix inspector-proxy to allow for DevTools requests with query strings Pull Request resolved: facebook#41005 Reviewed By: NickGerleman Differential Revision: D50342265 Pulled By: robhogan fbshipit-source-id: a65f2908f0bea9fc15e1e3e4e6d31a3b9598e81f * Make sure buildConfig is turned on for all the 3rd party libraries (facebook#40939) Summary: Pull Request resolved: facebook#40939 Currently some libs on RN 0.73 are broken as the default for Build Config generation changed from true to false since AGP 8.x. This reverts the behavior to the old flag. Closes facebook#40791 Closes facebook#40559 Changelog: [Internal] [Changed] - Make sure buildConfig is turned on for all the 3rd party libraries Reviewed By: mdvacca Differential Revision: D50270382 fbshipit-source-id: 02dcb031c577f65be2f41d9da0334c1b3d89e4c5 * Configure Java toolchains only when executing App configuration (facebook#40757) Summary: Fix facebook#40560 ## Changelog: [ANDROID] [FIXED] - Ensure that `configureJavaToolChains` is only executed once during configuration Pull Request resolved: facebook#40757 Test Plan: - Create a fresh `react-native@0.73.0-rc.1` project - Install `react-native-webview` - Apply [this patch](https://github.com/react-native-webview/react-native-webview/pull/3175/files) for `react-native-webview` (caused by another issue facebook#40559) - Edit `android/gradle.properties` and set `newArchEnabled` to true - Build application - (Expected) Application fail to build - Apply this PR - (Expected) Application build successfully **Additional explanation:** According to the implementation of `configureJavaToolChains`, all the subprojects (both the app and the libraries) will have their toolchains setup in one execution of the method. Therefore, it is okay for the method to be invoked only when configuring the plugin for the app. On the other hand, invoking the method for more than one time will cause the issue stated in facebook#40560. Reviewed By: cipolleschi Differential Revision: D50361871 Pulled By: cortinico fbshipit-source-id: bd5e18df97988122788d0482dba954e517a0cb5c * Fix instacrash on bridgeless due to calling showMessage on null instance (facebook#39834) Summary: Pull Request resolved: facebook#39834 Bridgeless is instacrashing on fast-refresh. This fixes it. Changelog: [Android] [Fixed] - Fix instacrash on bridgeless due to calling showMessage on null instance Reviewed By: cipolleschi Differential Revision: D49929822 fbshipit-source-id: a2ce65797abd34d6a3e2b7f2c50d38a62ea8bdea * Re-introduce FabricViewStateManager interface (facebook#40998) Summary: Pull Request resolved: facebook#40998 changelog: [Android] Add back interface FabricViewStateManager to unblock 0.73 I incorrectly deleted FabricViewStateManager in D47993140. This is a breaking change even for old architecture. Let's add it back and mark it as deprected so we can remove it later on. This interface is not used in react-native anymore. We are removing FabricViewStateManager because it simply wraps StateWrapper and provides no additional anymore. Reviewed By: cortinico Differential Revision: D50318633 fbshipit-source-id: aeb1c66c35018e336339616b564dee6f3156b54b * Add ExceptionsManagerModule for RNTester (facebook#40767) Summary: Pull Request resolved: facebook#40767 Fix the following issue: ```Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'ExceptionsManager' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode: true. TurboModule interop: true. Modules loaded: {"NativeModules":[],"TurboModules": ["PlatformConstants","AppState","SourceCode","BlobModule","WebSocketModule","DevSettings","DevToolsSettingsManager","LogBox","Networking","Appearance","DevLoadingView","DeviceInfo","DeviceEventManager", "SoundManager","ImageLoader","DialogManagerAndroid","NativeAnimatedModule","I18nManager","AccessibilityInfo","StatusBarManager","StatusBarManager","IntentAndroid","ToastAndroid","ShareModule","Vibration"], "NotFound":["NativePerformanceCxx","NativePerformanceObserverCxx","RedBox","BugReporting","HeadlessJsTaskSupport","FrameRateLogger","KeyboardObserver", "AccessibilityManager","ModalManager","LinkingManager","ActionSheetManager","ExceptionsManager"]} ``` Changelog: [Android][Changed] - Add Add ExceptionsManagerModule to CoreReactPackage Reviewed By: cortinico Differential Revision: D50017783 fbshipit-source-id: 8642bb23bdae50a1e702f5e0586b0ede80007bb1 # Conflicts: # packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.kt * Fix compilation warnings introduced by Gradle 8.4 (facebook#39959) Summary: Pull Request resolved: facebook#39959 We're still accessing project.buildDir which will be removed in Gradle 9.0 I'm cleaning it up here. Changelog: [Internal] [Changed] - Fix compilation warnings introduced by Gradle 8.4 Reviewed By: yungsters Differential Revision: D50016573 fbshipit-source-id: de7a725f61b503f08991ebf85b9a002cefab221a * update: fresco 3.0.0 -> 3.1.0 (facebook#41024) Summary: - ref: reactwg/react-native-releases#64 (comment) With react-native@0.73.0-rc.2 and fresco@3.0.0, `dlopen failed: library "libnative-imagetranscoder.so"` error made crash in android. so, I patched fresco version to 3.1.0, so that resolves the crash error according to facebook/fresco#2722 (comment) this comment. ## Changelog:  [ANDROID] [FIXED] - b1fccb0 bumped fresco version to 3.1.0. Pull Request resolved: facebook#41024 Test Plan: after bumping fresco version, error not occurs. Reviewed By: cipolleschi Differential Revision: D50359564 Pulled By: cortinico fbshipit-source-id: d24caecc057bad4d9c94e378422ab18c106a7ee6 # Conflicts: # packages/react-native/gradle/libs.versions.toml * Rename `RCTRootViewFrameDidChangeNotification` as it's not trac… (facebook#39835) Summary: …king root view frame changes Looking through where this was introduced (facebook#37649), it seems the notification went from tracking root view size changes to window size changes. However, it was not renamed. I was using it for root view changes in RN-macOS, which.. I guess I'll refactor. Meanwhile, let's update the name? ## Changelog: [IOS] [CHANGED] - Rename `RCTRootViewFrameDidChangeNotification` as it's not tracking root view frame changes Pull Request resolved: facebook#39835 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D50173742 Pulled By: javache fbshipit-source-id: 4651696174c439800984a5e6cf642200bb9c4f3c * Fix unstable RCTAppDelegate podspec (facebook#41009) Summary: Pull Request resolved: facebook#41009 This change should fix [facebook#39971](facebook#39971), computing the relative path from the App path to the pod installation root and using that instead of the absolute path to the `react-native.config.js` file ## Changelog [Internal] - Stabilize RCTAppDelegate podspec Reviewed By: cortinico Differential Revision: D50323710 fbshipit-source-id: e29e62228d08c752e822d7a9ab5b1a2b5dcd6eb4 * Symbolicate unhandled promise rejections (facebook#40914) Summary: For a very long time when a promise rejects without an attached catch we get this warning screen without a correct stack trace, only some internal calls to the RN internals. <img src="https://github.com/facebook/react-native/assets/1634213/75aa7615-ee3e-4229-80d6-1744130de6e5" width="200" /> I created [an issue for discussion](react-native-community/discussions-and-proposals#718) in the react-native-community repo and we figured out it was only a matter of symbolication. While it cannot be done on release without external packages and source maps, at least while developing we can provide a symbolicated stack-trace so developers can better debug the source of rejected promise. I got the stack trace symbolicated and the correct code frame. I'm missing some help trying to display it in the warning view but at the very least I can now correctly show the line of the error and log the codeframe to the console. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [FIXED] - Show correct stack frame on unhandled promise rejections on development mode. For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook#40914 Test Plan: I simply created a throwing function on a dummy app, and checked the output of the console and the warning view: ```ts import React from 'react'; import {SafeAreaView, Text} from 'react-native'; async function throwme() { throw new Error('UNHANDLED'); } function App(): JSX.Element { throwme(); return ( <SafeAreaView> <Text>Throw test</Text> </SafeAreaView> ); } export default App; ``` Here is the output <img src="https://github.com/facebook/react-native/assets/1634213/2c100e4d-618e-4143-8d64-4095e8370f4f" width="200" /> Edit: I got the warning window working properly: <img src="https://github.com/facebook/react-native/assets/1634213/f02a2568-da3e-4daa-8132-e05cbe591737" width="200" /> Reviewed By: yungsters Differential Revision: D50324344 Pulled By: javache fbshipit-source-id: 66850312d444cf1ae5333b493222ae0868d47056 * Align all the pods to 13.4 (facebook#41050) Summary: Pull Request resolved: facebook#41050 This change aligns all the podspecs to 13.4, including 3rd party libraries. This should fix facebook#39826 ## Changelog [iOS][Changed] - Align all pods to 13.4 Reviewed By: huntie Differential Revision: D50405114 fbshipit-source-id: 2d1b50ed8433e8cdc2214eb17e15be6ea81107a1 # Conflicts: # packages/react-native/scripts/cocoapods/utils.rb * Bump SocketRocket to 0.6.1 (facebook#40774) Summary: The SocketRocket version was upgraded to 0.6.1 on the 0.72-stable branch but for some reason it was not updated in main, causing a downgrade when running `pod install` with 0.73.0 RC1 Original commit bumping SocketRocket -> facebook@8ce471e ## Changelog: [IOS] [CHANGED] - Bump SocketRocket to 0.6.1 Pull Request resolved: facebook#40774 Test Plan: Run rntester locally Reviewed By: cipolleschi Differential Revision: D50137261 Pulled By: arushikesarwani94 fbshipit-source-id: dfc2760f5d5611881126ad114d8f6ada23630a29 # Conflicts: # packages/react-native/React-Core.podspec # packages/react-native/React/CoreModules/React-CoreModules.podspec # packages/rn-tester/Podfile.lock * Bump RNTester Cocoapods cache keys after SocketRocket 6.1.0 bump (facebook#40789) Summary: Commit 8b88883 broke the Cache for RNTester because the cached version of the pods does not know about the exitence of SocketRocket 6.1.0 Bumping the keys should force a redownload of the cocoapods specs repo ## Changelog: [Internal] - Bump RNTester cache keys Pull Request resolved: facebook#40789 Test Plan: CircleCI is green Reviewed By: GijsWeterings Differential Revision: D50169281 Pulled By: cipolleschi fbshipit-source-id: 83e251495bfa43d62384470efe97c5505d76684f # Conflicts: # packages/rn-tester/Podfile.lock * Revert "Add ExceptionsManagerModule for RNTester (facebook#40767)" This reverts commit 034d815. * rewrite RNTesterApplication to kotlin (facebook#39557) Summary: Rewrite `RNTesterApplication` to Kotlin as per [Help us Kotlin-ify React Native tests - Round 2](facebook#38825) ## Changelog: [ANDROID] [CHANGED] - Rewrite RNTesterApplication to Kotlin, add AnnotationTarget property. Pull Request resolved: facebook#39557 Test Plan: `yarn && yarn android` ✅ The only thing I'm kinda unsure of is whether `AnnotationTarget.PROPERTY` should be added, but it didn't let me annotate `reactHostInterface` without that and didn't compile. <img width="637" alt="image" src="https://github.com/facebook/react-native/assets/33528752/8bc84870-f3f2-4a46-b076-6ee7e38bd735"> cortinico mdvacca Reviewed By: cortinico Differential Revision: D49598401 Pulled By: mdvacca fbshipit-source-id: 105ae0c13c93dae0eeb2b6fa9040f03f42d2736a * Do not guard initializeFlipper for bridgeless for RN Tester Summary: We don't need this if-than-else because the initializeFlipper already checks if we're on bridgeless or not Changelog: [Internal] [Changed] - Do not guard initializeFlipper for bridgeless for RN Tester Reviewed By: NickGerleman Differential Revision: D49881903 fbshipit-source-id: e6bfc941b43382580bd418a5f27ad9426d300c69 * Fix new arch example not render in RNTester (facebook#39810) Summary: Pull Request resolved: facebook#39810 Two issues will be fixed: - Bridgeless has lazy view manager loading by default so the React Package that provides view managers must implement ViewManagerOnDemandReactPackage, we might could refactor the design of package classes later - ThemedReactContext should **NOT** be used directly to call function ```getJSModule```, since it doesn't overrides ```getJSModule``` for Bridgeless, we can use it's internal variable ```meactApplicationContext``` which should be an instance of BridgelessReactContext Reviewed By: cortinico Differential Revision: D49912656 fbshipit-source-id: a0bdd717612398e8d7a6f36d36dba241a3b06bd7 * Move ReactHost to com.facebook.react (facebook#39769) Summary: Pull Request resolved: facebook#39769 Move ReactHost to com.facebook.react bypass-github-export-checks changelog: [internal] internal Reviewed By: javache Differential Revision: D49834870 fbshipit-source-id: 2cfdd34297399115457424f0ba1279fd477da4a1 * Add rn-tester Android BUCK configuration (facebook#39987) Summary: Pull Request resolved: facebook#39987 Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D49983211 fbshipit-source-id: c362d5b93e159bfb5ca17bea0ec0484adcdb4dca * Add ExceptionsManagerModule for RNTester (facebook#40767) Summary: Pull Request resolved: facebook#40767 Fix the following issue: ```Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'ExceptionsManager' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode: true. TurboModule interop: true. Modules loaded: {"NativeModules":[],"TurboModules": ["PlatformConstants","AppState","SourceCode","BlobModule","WebSocketModule","DevSettings","DevToolsSettingsManager","LogBox","Networking","Appearance","DevLoadingView","DeviceInfo","DeviceEventManager", "SoundManager","ImageLoader","DialogManagerAndroid","NativeAnimatedModule","I18nManager","AccessibilityInfo","StatusBarManager","StatusBarManager","IntentAndroid","ToastAndroid","ShareModule","Vibration"], "NotFound":["NativePerformanceCxx","NativePerformanceObserverCxx","RedBox","BugReporting","HeadlessJsTaskSupport","FrameRateLogger","KeyboardObserver", "AccessibilityManager","ModalManager","LinkingManager","ActionSheetManager","ExceptionsManager"]} ``` Changelog: [Android][Changed] - Add Add ExceptionsManagerModule to CoreReactPackage Reviewed By: cortinico Differential Revision: D50017783 fbshipit-source-id: 8642bb23bdae50a1e702f5e0586b0ede80007bb1 * Make sure onIntArrayChanged is invoked on RN Tester (facebook#40940) Summary: Pull Request resolved: facebook#40940 Currently the `onIntArrayChanged` event is invoked only once inside RN Tester. I'm changing the logic to make sure it fires whenever we click "Set Opacity" Changelog: [Internal] [Changed] - Make sure onIntArrayChanged is invoked on RN Tester Reviewed By: mdvacca, dmytrorykun Differential Revision: D50264765 fbshipit-source-id: 93a60fd1b657c3d8b8182cab6bb7cd4368ac9a42 * Fix broken Fabric Interop example (facebook#40942) Summary: Pull Request resolved: facebook#40942 The Fabric Interop example for Android is broken. This is due to the Kotlin conversion which moved the `Color.colorToHSV(color, hsv)` statement *after* the HSV array is read so the array is always [0,0,0]. I'm fixing it here. Changelog: [Internal] [Changed] - Fix broken Fabric Interop example Reviewed By: cipolleschi Differential Revision: D50264766 fbshipit-source-id: 27ae5289408c7c23c667d6d7112437fa7ebe36d5 * Simplify new app template for bridgeless (facebook#40929) Summary: Pull Request resolved: facebook#40929 This diff reduces the footprint that bridgeless is imposing on the new app template. Specifically: - I've created a `.toReactHost` method that converts a DefaultReactNativeHost to a DefaultReactHost - I've updated RN Tester to use the same setup as the New App template which reduces code duplication. I also had to remove a couple of `UnstableReactNativeAPI` as those were bleeding in the new app template. I don't think we should ask users to opt-in in `UnstableReactNativeAPI` in the New App template itself as this means that all the apps will get this opt-in. Instead we should keep it only for specific APIs that we want the users to opt into. Changelog: [Internal] [Changed] - Simplify new app template for bridgeless Reviewed By: cipolleschi, luluwu2032 Differential Revision: D50227693 fbshipit-source-id: e86c54d5156cc27f1f898b43ca89c57d5cf148b8 * Make events work for Fabric Interop on Bridgeless (facebook#40941) Summary: Pull Request resolved: facebook#40941 Events are currently not working for Fabric Interop on Bridgeless. That's because the `BridgelessReactContext` is not checking for interop modules on `getJsModule` calls, so the `InteropEventEmitter` is never returned. This extends `BridgelessReactContext` so that `InteropEventEmitter` is returned if the Interop Layer is turned on. Changelog: [Internal] [Changed] - Make events work for Fabric Interop on Bridgeless Reviewed By: cipolleschi Differential Revision: D50266484 fbshipit-source-id: 0188d71bdc7acc8c188d886d45f0258914ad7af7 * Make IntArray events work on Bridgeless for RN-Tester (facebook#41047) Summary: Pull Request resolved: facebook#41047 Array events are currently broken in the sample for RN Tester. This is because the event name is not registered correctly. I'm updating the event registration to be correct. Changelog: [Internal] [Changed] - Make IntArray events work on Bridgeless for RN-Tester Reviewed By: cipolleschi Differential Revision: D50266485 fbshipit-source-id: 13bbce91a41281383d4857048e573b6d9cc5387b * Bump package versions #publish-packages-to-npm * Make hermes build fetching more flavour resilient (facebook#41055) Summary: Pull Request resolved: facebook#41055 This should fix the issue highlighted in [this comment](reactwg/react-native-releases#64 (comment)). Basically, before the fix, we were not supporting flavours correctly, as we assumed that only Debug and Release were available. With this change, we infer whether we have to fetch Hermes for Debug or Release based on the actual flags that are passed. In this way, the users can customize their app's flavors more freely. ## Changelog: [Internal] - Support multiple flavors when downloading Hermes Reviewed By: huntie Differential Revision: D50408381 fbshipit-source-id: 6990218b286b4dd823323bc63de90279efc9e74e * Fix Glog for earlier versions of Xcode (facebook#41058) Summary: Pull Request resolved: facebook#41058 Glog has a piece of code which looks like this: ``` namespace google { // They need the definitions of integer types. #include "glog/log_severity.h" #include "glog/vlog_is_on.h" ``` This fragment is: - Always valid when the pod does not define a module - Valid for Xcode >= 14.3, when the pod do define a module - Invalid for Xcode < 14.3, when the pod do define a module Modules are required to support Swift, so, in the long run, we want to have `DEFINES_MODULE` set to `YES` for `Glog`. This is a temporary workaround to keep supporting older versions of Xcode while Apple keeps allowing to use Xcode 14.1 to submit apps to the store. Historically, Apple pushes the minimum version of Xcode every April, so we expect to be able to remove this workaround in April 2024. ## Changelog: [Internal] - Make Glog work with older versions of Xcode Reviewed By: cortinico Differential Revision: D50410487 fbshipit-source-id: 96145cdf9ba1bc75622403d3c06454d6d4bfd967 * Make the Fabric Interop layer work in Bridgeless (facebook#40732) Summary: Pull Request resolved: facebook#40732 This change allows the Fabric Interop Layer to work in bridgeless mode. Given that the legacy components requires a Bridge to send events and use commands, this change simulates a bridge when it doesn't exists (i.e.: we are in bridgeless mode). In order to make it work, we had to simulate a few elements from the Bridge and the UIManager. ## Changelog: [iOS][Fixed] - Make the Fabric interop layer works in bridgeless mode. ## Facebook: As an alternative approach, we could have created a `protocol RCTBridging`, have the `RCTBridge` conform to that protocol, and create a new type for it. Practically this would have been much more cumbersome: 1. The [RCTBridge](https://www.internalfb.com/code/fbsource/[916531b9bf7a9943036807f7563c925b4c3e0101]/xplat/js/react-native-github/packages/react-native/React/Base/RCTBridge.h?lines=87-238) interface is quite big. All the props and method should be part of the protocol. 2. Extensions declared on RCTBridge would not have worked. For example, [`RCTBridge (RCTUIManager)`](https://www.internalfb.com/code/fbsource/[916531b9bf7a9943036807f7563c925b4c3e0101]/xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.h?lines=170-174). 3. It would require a major overhaul of the APIs, returning `id<RCTBridging>` in place of **every** function that takes/return an instance of `RCTBridge *`. Clearly, not a feasible way to go. Reviewed By: RSNara Differential Revision: D50079929 fbshipit-source-id: 77d4370e9043c8e06b676bff3987511c042b0f9c * [0.73.0-rc.3] Bump version numbers * Remove deprecated jsinspector files (facebook#41159) Summary: Pull Request resolved: facebook#41159 Changelog: [Internal] Cleanup from D48966244. The deprecated `jsinspector` files are no longer used by any code in either fbsource or `react-native`. Reviewed By: hoxyq Differential Revision: D50530796 fbshipit-source-id: b539b097cb6caf6c50a482fa93bf5d7886e76e52 * [LOCAL] Fix e2e script for 0.73 * [LOCAL] Run prettier * [LOCAL] Update Podfile.lock * Update Metro to ^0.80.0, don't pin to exact version cherry-pick 7853b06 * cipolleschi/fix test script (facebook#41267) * [0.73] Collection of Android picks for RC4 (facebook#41221) Co-authored-by: Lulu Wu <luluwu@meta.com> Co-authored-by: Gabriel Donadel <donadeldev@gmail.com> fix `java.lang.NoSuchMethodError` for Bridgeless (facebook#41081) resolved: facebook#41081 resolved: facebook#40999 resolved: facebook#41165 Fix RNTester not showing Redbox when Metro is not connected (facebook#41191) resolved: facebook#41191 resolved: facebook#41190 resolved: facebook#41085 resolved: facebook#41206 * Build fixes --------- Co-authored-by: Alex Hunt <hello@alexhunt.io> Co-authored-by: Luna Wei <luwe@fb.com> Co-authored-by: Dmitry Rykun <dmitryrykun@meta.com> Co-authored-by: Lulu Wu <luluwu@meta.com> Co-authored-by: Alex Hunt <alexeh@meta.com> Co-authored-by: Arushi Kesarwani <arushikesarwani@meta.com> Co-authored-by: Ramanpreet Nara <ramanpreet@meta.com> Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com> Co-authored-by: Alex Hunt <huntie@meta.com> Co-authored-by: David Vacca <dvacca@meta.com> Co-authored-by: Distiller <distiller@static.198.206.135.134.macminivault.com> Co-authored-by: Distiller <distiller@static.38.23.39.57.cyberlynk.net> Co-authored-by: Distiller <distiller@static.38.23.38.177.cyberlynk.net> Co-authored-by: Thibault Malbranche <malbranche.thibault@gmail.com> Co-authored-by: Distiller <distiller@static.38.23.40.157.cyberlynk.net> Co-authored-by: Nicola Corti <ncor@meta.com> Co-authored-by: Nishan <nishanbende@gmail.com> Co-authored-by: Luna Wei <luwe@meta.com> Co-authored-by: Distiller <distiller@static.38.23.40.28.cyberlynk.net> Co-authored-by: Nick Gerleman <ngerlem@meta.com> Co-authored-by: Blake Friedman <blakef@meta.com> Co-authored-by: 116-7 <1167@local> Co-authored-by: UNIDY2002 <UNIDY2002@outlook.com> Co-authored-by: Samuel Susla <samuelsusla@meta.com> Co-authored-by: DeokHyeon Wi <dnl9807@gmail.com> Co-authored-by: Oscar Franco <ospfranco@gmail.com> Co-authored-by: Gabriel Donadel <donadeldev@gmail.com> Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com> Co-authored-by: Oleksii <alexx271298@gmail.com> Co-authored-by: Christoph Purrer <chpurrer@meta.com> Co-authored-by: Distiller <distiller@static.38.39.184.83.cyberlynk.net> Co-authored-by: Moti Zilberman <moti@meta.com> Co-authored-by: Rob Hogan <rob@rhogan.net>

kuzkokov · 2024-01-31T17:29:08Z

hi, @cipolleschi
are you sure that this is actually correct?

This fragment is:

Always valid when the pod does not define a module

Valid for Xcode >= 14.3, when the pod do define a module

Invalid for Xcode < 14.3, when the pod do define a module

it seems that this commit causes errors on XCode 14.2 during pod install (like this one that I have and probably this one too).
I've just upgraded my project to the RN v0.73.2, and this begin to happen, because I use expo-sdk (and XCode 14.2), and if I understand correctly ExpoModulesCore defines a module:

s.pod_target_xcconfig = {
    'USE_HEADERMAP' => 'YES',
    'DEFINES_MODULE' => 'YES',
    'CLANG_CXX_LANGUAGE_STANDARD' => 'c++17',
    'SWIFT_COMPILATION_MODE' => 'wholemodule',
    'HEADER_SEARCH_PATHS' => header_search_paths.join(' '),
    "FRAMEWORK_SEARCH_PATHS" => "\"${PODS_CONFIGURATION_BUILD_DIR}/React-hermes\"",
    'OTHER_SWIFT_FLAGS' => "$(inherited) #{fabric_enabled ? fabric_compiler_flags : ''}"
  }

I may be mistaken cause I don't understand much about all that native side, but anyway I edited glog.podspec locally in node_modules to basically revert this commit, and with "DEFINES_MODULE" => "YES" pods installed without errors.

I also tried to create fresh project with npx create-expo-app --template choosing Bare template, and the error persisted.

so... what do you think?

cipolleschi · 2024-01-31T17:45:48Z

Details are a little blurried now, as the PR is from 4 months ago. When I tested it, DEFINE_MODULES was not working with Xcode 14.1 and 14.2, but was working and required for Xcode >= 14.3.

It's much more trickier to test this now, because the newest MacOS does not allow us to run versions of Xcode older than 15. Expo should have already fixed that, so I suggest to make sure that all the Expo dependencies are properly configured.

kuzkokov · 2024-02-05T12:04:21Z

it's not only the expo issue, in the message above I linked the same issue at the react-native-google-mobile-ads.

do you recall how did you test it? maybe I can try to reproduce your tests and compare them with mine

kuzkokov · 2024-02-09T18:18:03Z

nevermind, the latest cocoapods fixes it

andy380743909 · 2024-02-21T10:04:46Z

Xcode: 14.2
cocoapods: 1.15.2

after manually modify the glob podspec to "DEFINES_MODULE" => "YES" only make the pod install success, but the build failed with errors:

/Users/andy/Workspace/ReactNativeApps/AwesomeProject/ios/Pods/Headers/Public/glog/glog/logging.h:512:1: Import of module 'glog.glog.log_severity' appears within namespace 'google'

Finally, this works for me.

#41045 (comment)

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2023

facebook-github-bot added p: Facebook Partner: Facebook Partner fb-exported labels Oct 18, 2023

tido64 reviewed Oct 18, 2023

View reviewed changes

cipolleschi force-pushed the export-D50410487 branch from 475e0d7 to fceeae2 Compare October 18, 2023 14:42

cipolleschi force-pushed the export-D50410487 branch from fceeae2 to 620306f Compare October 18, 2023 14:42

cipolleschi force-pushed the export-D50410487 branch from 620306f to 0e6a027 Compare October 18, 2023 15:08

tido64 reviewed Oct 18, 2023

View reviewed changes

facebook-github-bot closed this in 1e5e3b5 Oct 18, 2023

facebook-github-bot added the Merged This PR has been merged. label Oct 18, 2023

This was referenced Oct 31, 2023

cipolleschi/fix test script #41267

Merged

[RN][CI]Update node installation on debian (0.73) #41275

Merged

Fix Test Windows (0.73) #41279

Closed

This was referenced Nov 23, 2023

Revert "RNTester-ios / RCTAppDelegate > correctly check for USE_HERMES Flag" #41622

Merged

[RN][iOS] Fix React-FabricImage dependencies #41641

Merged

cipolleschi mentioned this pull request Dec 28, 2023

[RN][CI] Fix e2e test setup #42087

Merged

This was referenced Jan 8, 2024

[0.73][RN][General] Migrate boost download url away from JFrog #42176

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42227

Merged

cipolleschi mentioned this pull request Jan 19, 2024

[RN][iOS] Fix race condition between A11yManager and UIManager #42382

Merged

cipolleschi mentioned this pull request Jan 30, 2024

[RN][iOS] Fix warning when loading RCTUIManager and A11yManager #42734

Merged

kuzkokov mentioned this pull request Feb 5, 2024

[SDK 50] Pod install error: The Swift pod ExpoModulesCore depends upon glog, which does not define modules. expo/expo#25905

Closed

cipolleschi mentioned this pull request Feb 19, 2024

[RN][iOS] Fix compiler flags passed to libraries #43088

Merged

andy380743909 mentioned this pull request Feb 21, 2024

chore: use the macOS 13 runner callstack/react-native-builder-bob#523

Closed

This was referenced Feb 29, 2024

[RN][iOS]Rename BUILD_FROM_SOURCE to RCT_BUILD_HERMES_FROM_SOURCE #43246

Merged

[RN][iOS] Fix flipper for Xcode 15.3 #43341

Merged

stianjensen mentioned this pull request Mar 6, 2024

glog.podspec checksum is unstable (depending on Xcode version) reactwg/react-native-releases#122

Closed

cipolleschi mentioned this pull request Apr 5, 2024

[Yoga][0.73] Fix archive for MacOS Catalyst #43896

Merged

cipolleschi mentioned this pull request Jun 28, 2024

[CI] Move machines to M1 for 0.73 #45214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Glog for earlier versions of Xcode #41058

Fix Glog for earlier versions of Xcode #41058

cipolleschi commented Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

tido64 Oct 18, 2023

tido64 Oct 18, 2023

cipolleschi Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023 •

edited

Loading

tido64 Oct 18, 2023

tido64 Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

kuzkokov commented Jan 31, 2024

cipolleschi commented Jan 31, 2024

kuzkokov commented Feb 5, 2024

kuzkokov commented Feb 9, 2024

andy380743909 commented Feb 21, 2024

	should_define_modules = is_greater_than_15 ? "YES" : is_greater_than_14_3 ? "YES" : "NO"
	should_define_modules = is_greater_than_15 \|\| is_greater_than_14_3 ? "YES" : "NO"

Fix Glog for earlier versions of Xcode #41058

Fix Glog for earlier versions of Xcode #41058

Conversation

cipolleschi commented Oct 18, 2023

Changelog:

facebook-github-bot commented Oct 18, 2023

tido64 Oct 18, 2023

Choose a reason for hiding this comment

tido64 Oct 18, 2023

Choose a reason for hiding this comment

cipolleschi Oct 18, 2023

Choose a reason for hiding this comment

facebook-github-bot commented Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

facebook-github-bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023 • edited Loading

tido64 Oct 18, 2023

Choose a reason for hiding this comment

tido64 Oct 18, 2023

Choose a reason for hiding this comment

facebook-github-bot commented Oct 18, 2023

kuzkokov commented Jan 31, 2024

cipolleschi commented Jan 31, 2024

kuzkokov commented Feb 5, 2024

kuzkokov commented Feb 9, 2024

andy380743909 commented Feb 21, 2024

github-actions bot commented Oct 18, 2023 •

edited

Loading