Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React-Native-Restart in release #43645

Closed
wants to merge 1 commit into from
Closed

React-Native-Restart in release #43645

wants to merge 1 commit into from

Commits on Mar 26, 2024

  1. React-Native-Restart in release (facebook#43645) 

    Summary:

facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless.

Adding implementation of `DisabledDevSupportManager.handleReloadJS()` won't work as it would mean introducing circular dependency `devsupport` -> `runtime`

Reviewed By: cortinico

Differential Revision: D55342296
    @arushikesarwani94 @facebook-github-bot
    arushikesarwani94 authored and facebook-github-bot committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    fb40d87 View commit details
    Browse the repository at this point in the history