Kotlinify Dynamic #43905
Closed
Kotlinify Dynamic #43905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55793644 |
|
This pull request was exported from Phabricator. Differential Revision: D55793644 |
fabriziocucci
force-pushed
the
export-D55793644
branch
from
dd9443e
to
92a097a
Compare
fabriziocucci
added a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Reviewed By: cortinico Differential Revision: D55793644
fabriziocucci
force-pushed
the
export-D55793644
branch
from
92a097a
to
91c4911
Compare
fabriziocucci
added a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Reviewed By: cortinico Differential Revision: D55793644
|
This pull request was exported from Phabricator. Differential Revision: D55793644 |
Differential Revision: D55749364
Summary: Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55750840
Differential Revision: https://internalfb.com/D55751796
Differential Revision: D55752447
Differential Revision: D55753695
Differential Revision: D55764512
Summary: Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55766128
Summary: Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://www.internalfb.com/diff/D55767001?entry_point=27
Summary: Pull Request resolved: facebook#43891 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55788661
Differential Revision: D55789985
Differential Revision: D55790235
Differential Revision: D55790585
Differential Revision: D55791026
Differential Revision: D55791330
Differential Revision: D55793215
Differential Revision: D55793358
Differential Revision: D55793441
Summary: Pull Request resolved: facebook#43904 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793535
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Reviewed By: cortinico Differential Revision: D55793644
|
This pull request was exported from Phabricator. Differential Revision: D55793644 |
fabriziocucci
force-pushed
the
export-D55793644
branch
from
91c4911
to
d9e89b2
Compare
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
fabriziocucci
pushed a commit
to fabriziocucci/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43905 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Differential Revision: https://internalfb.com/D55793644
|
This pull request has been merged in 5927165. |
|
This pull request was successfully merged by @fabriziocucci in 5927165. When will my fix make it into a release? | How to file a pick request? |
3 tasks
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Jul 6, 2024
# Why In react-native 0.75 a lot of internal classes were migrated from Java to Kotlin, which led to some unexpected changes such as us no longer being able to access Java methods by skipping the "get" part. This was part of the Kotlinify effort on the repo and here is one example facebook/react-native#43905 Related to [ENG-12562](https://linear.app/expo/issue/ENG-12562) # How Update expo-modules-core to use getter methods in convertibles instead of # Test Plan Run BareExpo and FabricTester # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
As part of the Sustainability Week (see post).
Differential Revision: D55793644