[modules-core][android] Use getter methods in convertibles #30239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
approved these changes
Jul 6, 2024
lukmccall
approved these changes
Jul 6, 2024
expo-bot
added
bot: passed checks
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Jul 9, 2024
# Why In react-native 0.75 a lot of internal classes were migrated from Java to Kotlin, which led to some unexpected changes such as us no longer being able to access Java methods by skipping the "get" part (Same as #30239), this also affected react-native-safe-area-context and because of that it need to be updated to the latest version (Commit with the relevant changes th3rdwave/react-native-safe-area-context@05ad6b4 # How Bumped all packages/apps to use react-native-safe-area-context 4.10.7 # Test Plan - Expo Go - Bare Expo # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Jul 24, 2024
# Why upgrade react-native to 0.75 on main, the idea is that it should be backward compatible with SDK 51 Closes ENG-12562 # How - update package versions - `react-native 0.74.3 -> 0.75.0-rc.5` - `react 18.2.0 -> 19.0.0-rc-fb9a90fa48-20240614` - `react-dom 18.2.0 -> 19.0.0-rc-fb9a90fa48-20240614` - `react-test-renderer 18.2.0 -> 19.0.0-rc-fb9a90fa48-20240614` - upgrade project templates based on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.74.2&to=0.75.0-rc.2) - Set CXX language standard to c++20 on expo-av - Reverted #30239 because Kotlin getters were reverted in RC5 - [bare-expo][fabric-tester] Temporarily disabled DevClient (reenabled here -> #30545) - [cli ] Add `--config-cmd` option to `export:embed` (for additional info check facebook/react-native#45560) - [expo-go]react-native upgrade -> #30519 #### Libraries that need to be patched for now: - react-native-reanimated - react-native-pager-view - react-native-safe-area-context - react-native-screens - react-native # Test Plan - FabricTester - Crashing on Android - BareExpo # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In react-native 0.75 a lot of internal classes were migrated from Java to Kotlin, which led to some unexpected changes such as us no longer being able to access Java methods by skipping the "get" part. This was part of the Kotlinify effort on the repo and here is one example facebook/react-native#43905
Related to ENG-12562
How
Update expo-modules-core to use getter methods in convertibles instead of
Test Plan
Run BareExpo and FabricTester
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).