Restore CLI_PATH variable in react-native-xcode script #45560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This was referenced Jul 20, 2024
Closed
blakef
requested changes
Jul 22, 2024
|
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
blakef
approved these changes
Jul 22, 2024
|
This pull request was successfully merged by @gabrieldonadel in aa4f802 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Jul 22, 2024
Summary: When changing the `react-native-xcode.sh` logic to use the helloworld cli on #44721, the `CLI_PATH` env var was removed along with `BUNDLE_COMMAND`. Both of these values were used by Expo to override the default CLI and use our custom bundling command. https://github.com/expo/expo/blob/10e302ee13add0e24a08c7ee792c2da50ace95a6/templates/expo-template-bare-minimum/ios/HelloWorld.xcodeproj/project.pbxproj#L215C4-L215C15 This restores the `CLI_PATH` variable and set the default value as `"$REACT_NATIVE_DIR/scripts/bundle.js"`, along with the `BUNDLE_COMMAND` variable. With this Expo and other frameworks can keep the ability to easily replace the internal CLI ## Changelog: [INTERNAL] [CHANGED] - Restore CLI_PATH variable in react-native-xcode script Pull Request resolved: #45560 Test Plan: Project compiles correctly on iOS Reviewed By: robhogan Differential Revision: D60035338 Pulled By: blakef fbshipit-source-id: 26583d11d9f573f7cfa405b68e0cc3304c3601df
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Jul 24, 2024
# Why upgrade react-native to 0.75 on main, the idea is that it should be backward compatible with SDK 51 Closes ENG-12562 # How - update package versions - `react-native 0.74.3 -> 0.75.0-rc.5` - `react 18.2.0 -> 19.0.0-rc-fb9a90fa48-20240614` - `react-dom 18.2.0 -> 19.0.0-rc-fb9a90fa48-20240614` - `react-test-renderer 18.2.0 -> 19.0.0-rc-fb9a90fa48-20240614` - upgrade project templates based on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.74.2&to=0.75.0-rc.2) - Set CXX language standard to c++20 on expo-av - Reverted #30239 because Kotlin getters were reverted in RC5 - [bare-expo][fabric-tester] Temporarily disabled DevClient (reenabled here -> #30545) - [cli ] Add `--config-cmd` option to `export:embed` (for additional info check facebook/react-native#45560) - [expo-go]react-native upgrade -> #30519 #### Libraries that need to be patched for now: - react-native-reanimated - react-native-pager-view - react-native-safe-area-context - react-native-screens - react-native # Test Plan - FabricTester - Crashing on Android - BareExpo # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
This was referenced Aug 15, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Summary: In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices. I have just brought back the initialization from the PR before that, so the bundle phase is successful. ## Changelog: [IOS][Fixed] - Add back the BUNDLE_COMMAND Pull Request resolved: #46495 Test Plan: I have bundled release builds in Xcode. Everything seems to be fine. Reviewed By: cortinico Differential Revision: D62846877 Pulled By: cipolleschi fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
blakef
pushed a commit
that referenced
this pull request
Sep 23, 2024
Summary: In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices. I have just brought back the initialization from the PR before that, so the bundle phase is successful. ## Changelog: [IOS][Fixed] - Add back the BUNDLE_COMMAND Pull Request resolved: #46495 Test Plan: I have bundled release builds in Xcode. Everything seems to be fine. Reviewed By: cortinico Differential Revision: D62846877 Pulled By: cipolleschi fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
blakef
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices. I have just brought back the initialization from the PR before that, so the bundle phase is successful. ## Changelog: [IOS][Fixed] - Add back the BUNDLE_COMMAND Pull Request resolved: #46495 Test Plan: I have bundled release builds in Xcode. Everything seems to be fine. Reviewed By: cortinico Differential Revision: D62846877 Pulled By: cipolleschi fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When changing the
react-native-xcode.shlogic to use the helloworld cli on #44721, theCLI_PATHenv var was removed along withBUNDLE_COMMAND. Both of these values were used by Expo to override the default CLI and use our custom bundling command.https://github.com/expo/expo/blob/10e302ee13add0e24a08c7ee792c2da50ace95a6/templates/expo-template-bare-minimum/ios/HelloWorld.xcodeproj/project.pbxproj#L215C4-L215C15
This restores the
CLI_PATHvariable and set the default value as"$REACT_NATIVE_DIR/scripts/bundle.js", along with theBUNDLE_COMMANDvariable. With this Expo and other frameworks can keep the ability to easily replace the internal CLIChangelog:
[INTERNAL] [CHANGED] - Restore CLI_PATH variable in react-native-xcode script
Test Plan:
Project compiles correctly on iOS