-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include information about text range changes in onChange #45248
Open
hannojg
wants to merge
5
commits into
facebook:main
Choose a base branch
from
hannojg:feat/native-text-range-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 2, 2024
This was referenced Jul 2, 2024
Base commit: c252460 |
hannojg
force-pushed
the
feat/native-text-range-updates
branch
3 times, most recently
from
July 2, 2024 14:24
e26ce7a
to
ffb06f8
Compare
hannojg
force-pushed
the
feat/native-text-range-updates
branch
from
July 2, 2024 14:42
ffb06f8
to
5bcdda8
Compare
facebook-github-bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 2, 2024
hannojg
added a commit
to margelo/react-native-live-markdown
that referenced
this pull request
Jul 2, 2024
To align with react native, see: facebook/react-native#45248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Pr provides a solution to:
By providing further information about the range in which a text has been changed in the
onChange
event users are able to implement<TextInputs />
that only apply partial text updates, thus avoiding race condition issues between the main/UI and JS thread.Changelog:
[ANDROID] [ADDED] - Add
start
,before
,count
info to the Textinput'sonChange
event[IOS] [ADDED] - Add
start
,before
,count
info to the Textinput'sonChange
eventTest Plan:
I added an example to the rn-tester app.
Screen.Recording.2024-07-02.at.15.33.29.mov