Delete CoreFeatures class #45626
Closed
Delete CoreFeatures class #45626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
mdvacca
force-pushed
the
export-D60137380
branch
from
a3f8cd8 to
934b9bc
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 24, 2024
Summary: Pull Request resolved: facebook#45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Differential Revision: D60137380
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 24, 2024
Summary: Pull Request resolved: facebook#45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Differential Revision: D60137380
mdvacca
force-pushed
the
export-D60137380
branch
from
934b9bc to
0af58ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 24, 2024
Summary: Pull Request resolved: facebook#45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Differential Revision: D60137380
mdvacca
force-pushed
the
export-D60137380
branch
from
0af58ae to
0453479
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 23, 2024
Summary: Pull Request resolved: facebook#45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Reviewed By: rubennorte Differential Revision: D60137380
mdvacca
force-pushed
the
export-D60137380
branch
from
0453479 to
6e0bce0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 23, 2024
Summary: Pull Request resolved: facebook#45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Reviewed By: rubennorte Differential Revision: D60137380
mdvacca
force-pushed
the
export-D60137380
branch
from
6e0bce0 to
e444250
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
Summary: Migrate enableCppPropsIteratorSetter to ReactNativeFeatureFlags changelog: [internal] internal Differential Revision: D60022936
Summary: I'm deleting CoreFeatures::excludeYogaFromRawProps in favor of ReactNativeFeatureFlags::excludeYogaFromRawProps(); changelog: [internal] internal Differential Revision: D60124448
Summary: Pull Request resolved: facebook#45626 I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags Reviewed By: rubennorte Differential Revision: D60137380
|
This pull request was exported from Phabricator. Differential Revision: D60137380 |
mdvacca
force-pushed
the
export-D60137380
branch
from
e444250 to
37c019e
Compare
|
This pull request has been merged in eddc0a1. |
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Jan 9, 2025
## Summary This PR removes `#include <react/utils/CoreFeatures.h>` in ReanimatedModuleProxy.cpp which breaks build on RN 0.77. See also facebook/react-native#45626 ## Test plan
tomekzaw
added a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Jan 9, 2025
This PR removes `#include <react/utils/CoreFeatures.h>` in ReanimatedModuleProxy.cpp which breaks build on RN 0.77. See also facebook/react-native#45626
tomekzaw
added a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Jan 13, 2025
This PR removes `#include <react/utils/CoreFeatures.h>` in ReanimatedModuleProxy.cpp which breaks build on RN 0.77. See also facebook/react-native#45626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags
changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags
Differential Revision: D60137380