Remove CoreFeatures.h include
#6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
added
the
Check compatibility
piaskowyk
approved these changes
Jan 8, 2025
tomekzaw
added a commit
that referenced
this pull request
Jan 9, 2025
This PR removes `#include <react/utils/CoreFeatures.h>` in ReanimatedModuleProxy.cpp which breaks build on RN 0.77. See also facebook/react-native#45626
This was referenced Jan 10, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
## Summary This PR bumps `react-native` in paper-example and fabric-example from `0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6. Apart from this, changes have been made in macos-example, tvos-example and web-example to align versions of common native dependencies so they are hoisted by yarn. I had to patch `@shopify/flash-list`: * Shopify/flash-list#1466 – fixes Android build * Shopify/flash-list#1041 – fixes `scrollTo` example Changes required by Reanimated to support RN 0.77 have been moved to separate PRs for the sake of atomicity and transparency: * #6875 * #6876 * #6883 * #6884 ## Test plan --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tomekzaw
added a commit
that referenced
this pull request
Jan 13, 2025
This PR removes `#include <react/utils/CoreFeatures.h>` in ReanimatedModuleProxy.cpp which breaks build on RN 0.77. See also facebook/react-native#45626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
#include <react/utils/CoreFeatures.h>in ReanimatedModuleProxy.cpp which breaks build on RN 0.77.See also facebook/react-native#45626
Test plan