Fix incorrect timing for events that do not update the UI #46253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61939260 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 28, 2024
Summary: Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Differential Revision: D61939910
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Differential Revision: D61939910
Differential Revision: D61939261
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910
Differential Revision: D61939910
|
This pull request was exported from Phabricator. Differential Revision: D61939260 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
…6253) Summary: Pull Request resolved: facebook#46253 Changelog: [internal] This is still internal because this API hasn't been publicly released yet. ## Context This fixes a problem in our implementation for Event Timing API with paint time reporting (currently gated behind `ReactNativeFeatureFlags::enableReportEventPaintTime`) where events that don't trigger UI changes would wait for the next (unrelated) UI change to finish the event timing information. ## Implementation We had this issue because we were relying on mount hooks to finish pending events. The problem is that if the event itself didn't cause a commit, the mount hook will not execute immediately, and we'll wait for the mount notification of whatever is the next change (in an arbitrary point in time in the future). The fix for this has several parts: 1. Modify `RuntimeScheduler` to start tracking which surface IDs are the rendering updates applying to. It makes sense to do this regardless because `RuntimeScheduler` implements the Event Loop, and the Event Loop is aware of "documents" on Web (and the equivalent are surfaces in RN). 2. Create a new hook in `RuntimeScheduler` to report events after the task has finished executing (which is already a step in the Event Loop on Web). This will pass the list of surface IDs with pending changes, so the listener can determine if the events should be finished already or they should wait for mount for those changes. 3. Integrate `EventPerformanceLogger` with `RuntimeScheduler` and add the proper logic to handle this. Reviewed By: sammy-SC, rshest Differential Revision: D61939260
rubennorte
force-pushed
the
export-D61939260
branch
from
fd82e1b to
83f0573
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910
|
This pull request was exported from Phabricator. Differential Revision: D61939260 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
…6253) Summary: Pull Request resolved: facebook#46253 Changelog: [internal] This is still internal because this API hasn't been publicly released yet. ## Context This fixes a problem in our implementation for Event Timing API with paint time reporting (currently gated behind `ReactNativeFeatureFlags::enableReportEventPaintTime`) where events that don't trigger UI changes would wait for the next (unrelated) UI change to finish the event timing information. ## Implementation We had this issue because we were relying on mount hooks to finish pending events. The problem is that if the event itself didn't cause a commit, the mount hook will not execute immediately, and we'll wait for the mount notification of whatever is the next change (in an arbitrary point in time in the future). The fix for this has several parts: 1. Modify `RuntimeScheduler` to start tracking which surface IDs are the rendering updates applying to. It makes sense to do this regardless because `RuntimeScheduler` implements the Event Loop, and the Event Loop is aware of "documents" on Web (and the equivalent are surfaces in RN). 2. Create a new hook in `RuntimeScheduler` to report events after the task has finished executing (which is already a step in the Event Loop on Web). This will pass the list of surface IDs with pending changes, so the listener can determine if the events should be finished already or they should wait for mount for those changes. 3. Integrate `EventPerformanceLogger` with `RuntimeScheduler` and add the proper logic to handle this. Reviewed By: sammy-SC, rshest Differential Revision: D61939260
rubennorte
force-pushed
the
export-D61939260
branch
from
83f0573 to
e7ecb2b
Compare
…6253) Summary: Pull Request resolved: facebook#46253 Changelog: [internal] This is still internal because this API hasn't been publicly released yet. ## Context This fixes a problem in our implementation for Event Timing API with paint time reporting (currently gated behind `ReactNativeFeatureFlags::enableReportEventPaintTime`) where events that don't trigger UI changes would wait for the next (unrelated) UI change to finish the event timing information. ## Implementation We had this issue because we were relying on mount hooks to finish pending events. The problem is that if the event itself didn't cause a commit, the mount hook will not execute immediately, and we'll wait for the mount notification of whatever is the next change (in an arbitrary point in time in the future). The fix for this has several parts: 1. Modify `RuntimeScheduler` to start tracking which surface IDs are the rendering updates applying to. It makes sense to do this regardless because `RuntimeScheduler` implements the Event Loop, and the Event Loop is aware of "documents" on Web (and the equivalent are surfaces in RN). 2. Create a new hook in `RuntimeScheduler` to report events after the task has finished executing (which is already a step in the Event Loop on Web). This will pass the list of surface IDs with pending changes, so the listener can determine if the events should be finished already or they should wait for mount for those changes. 3. Integrate `EventPerformanceLogger` with `RuntimeScheduler` and add the proper logic to handle this. Reviewed By: sammy-SC, rshest Differential Revision: D61939260
|
This pull request was exported from Phabricator. Differential Revision: D61939260 |
rubennorte
force-pushed
the
export-D61939260
branch
from
e7ecb2b to
2715213
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: #46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for #46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910 fbshipit-source-id: 6dd6bc55fc6d4aa6cf8a535080c14a7a5b573b71
|
This pull request has been merged in 610212d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This is still internal because this API hasn't been publicly released yet.
This fixes a problem in our implementation for Event Timing API with paint time reporting (currently gated behind
ReactNativeFeatureFlags::enableReportEventPaintTime) where events that don't trigger UI changes would wait for the next (unrelated) UI change to finish the event timing information.Differential Revision: D61939260