Add surfaceId to EventTarget #46254
Closed
Add surfaceId to EventTarget #46254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61939910 |
|
This pull request was exported from Phabricator. Differential Revision: D61939910 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Differential Revision: D61939910
rubennorte
force-pushed
the
export-D61939910
branch
from
55f0f70 to
4d51fde
Compare
Differential Revision: D61939261
|
This pull request was exported from Phabricator. Differential Revision: D61939910 |
rubennorte
force-pushed
the
export-D61939910
branch
from
4d51fde to
bf2a50b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910
|
This pull request was exported from Phabricator. Differential Revision: D61939910 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910
rubennorte
force-pushed
the
export-D61939910
branch
from
bf2a50b to
db0adcb
Compare
Summary: Pull Request resolved: facebook#46254 Changelog: [internal] Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID. This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code. This is a dependency for facebook#46253 / D61939260, split to simplify reviewing. Reviewed By: sammy-SC, rshest Differential Revision: D61939910
|
This pull request was exported from Phabricator. Differential Revision: D61939910 |
rubennorte
force-pushed
the
export-D61939910
branch
from
db0adcb to
5b09769
Compare
|
This pull request has been merged in c6aa9f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Right now it's very hard to access the surface ID from the target when dispatching events, and we need that to determine if the event we dispatched produced any updates its surface ID.
This adds surfaceId to EventTarget so we can access it without an unnecessary large amount of indirection in the current code.
This is a dependency for #46253 / D61939260, split to simplify reviewing.
Differential Revision: D61939910