Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated: Refactor NativeAnimatedHelper #46312

Closed
wants to merge 2 commits into from

Conversation

yungsters
Copy link
Contributor

Summary:
Refactors NativeAnimatedHelper to make it easier to read, reduce runtime overhead, and no longer export queueOperation (which was not useable externally anyway).

Changelog:
[Internal]

Differential Revision: D62139993

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Differential Revision: D62139993
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Differential Revision: D62139993
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Differential Revision: D62139993
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 3, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 4, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 4, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
Summary:
Pull Request resolved: facebook#46318

Configures the Metro by default to use the Hermes parser so that React Native can fully leverage all modern Flow language syntax.

NOTE: This does not affect `*.ts` and `*.tsx` files which will continue to use Babel. Metro has logic to enforce this regardless of the transform options.

Changelog:
[General][Changed] - Changed Metro default config to use Hermes parser, enabling the use of advanced Flow syntax in React Native.

Differential Revision: D62161923
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 4, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 4, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62139993

yungsters added a commit to yungsters/react-native that referenced this pull request Sep 4, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 6, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 6, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
yungsters added a commit to yungsters/react-native that referenced this pull request Sep 6, 2024
Summary:
Pull Request resolved: facebook#46312

Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway).

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D62139993
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9e35dff.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @yungsters in 9e35dff

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants