Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'[skip ci] fix: ReactDevToolsSettingsManagerModule in ReactModuleList for android #46665

Closed
wants to merge 5 commits into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Sep 26, 2024

Summary:

Changelog: [Internal]

Looks like this module was missing on android for a while.

Differential Revision: D63460309

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63460309

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63460309

hoxyq added a commit to hoxyq/react-native that referenced this pull request Sep 26, 2024
facebook#46665)

Summary:
Pull Request resolved: facebook#46665

# Changelog: [Internal]

Looks like this module was missing on android for a while.

Differential Revision: D63460309
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63460309

hoxyq added a commit to hoxyq/react-native that referenced this pull request Sep 26, 2024
facebook#46665)

Summary:
Pull Request resolved: facebook#46665

# Changelog: [Internal]

Looks like this module was missing on android for a while.

Differential Revision: D63460309
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63460309

hoxyq added a commit to hoxyq/react-native that referenced this pull request Sep 26, 2024
facebook#46665)

Summary:
Pull Request resolved: facebook#46665

# Changelog: [Internal]

Looks like this module was missing on android for a while.

Reviewed By: huntie

Differential Revision: D63460309
Summary:
# Changelog:

allow-large-files

Differential Revision: D63460308
Summary:
Changelog: [Internal] - Update `react-native/debugger-frontend` from e8c7943...87b2feb

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebookexperimental/rn-chrome-devtools-frontend@e8c7943...87b2feb).

Differential Revision: D63455520
Summary:
# Changelog: [Internal]

In React DevTools 6.0.0, settings manager is [no longer used](facebook/react#30986), because the host of the Backend is responsible for settings persistance.

Also, `installHook()` call was removed from the top level of the JavaScript module and now we need to call `initialize()` explicitly.

The logic for persisting settings will be added in one of the next diffs at the top.

Differential Revision: D62967059
…ings

Summary:
# Changelog: [Internal]

This should not have been a public API in the first place.

1. Moving this to `src/private`.
2. Removed some unused APIs, such as profiling settings.

Differential Revision: D62965492
facebook#46665)

Summary:
Pull Request resolved: facebook#46665

# Changelog: [Internal]

Looks like this module was missing on android for a while.

Reviewed By: huntie

Differential Revision: D63460309
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63460309

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 37756d7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants