Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'[skip ci] fix: ReactDevToolsSettingsManagerModule in ReactModuleList for android #46665

Closed
wants to merge 5 commits into from
Closed

'[skip ci] fix: ReactDevToolsSettingsManagerModule in ReactModuleList for android #46665

wants to merge 5 commits into from

Commits on Sep 27, 2024

  1. upgrade[react-devtools-core]: 6.0.0 

    Summary:
# Changelog:

allow-large-files

Differential Revision: D63460308
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2f825fc View commit details
    Browse the repository at this point in the history

  2. Update debugger-frontend from e8c7943...87b2feb 

    Summary:
Changelog: [Internal] - Update `react-native/debugger-frontend` from e8c7943...87b2feb

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebookexperimental/rn-chrome-devtools-frontend@e8c7943...87b2feb).

Differential Revision: D63455520
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ca653d3 View commit details
    Browse the repository at this point in the history

  3. upgrade React Native on a new RDT backend 

    Summary:
# Changelog: [Internal]

In React DevTools 6.0.0, settings manager is [no longer used](facebook/react#30986), because the host of the Backend is responsible for settings persistance.

Also, `installHook()` call was removed from the top level of the JavaScript module and now we need to call `initialize()` explicitly.

The logic for persisting settings will be added in one of the next diffs at the top.

Differential Revision: D62967059
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f9fa296 View commit details
    Browse the repository at this point in the history

  4. Libraries/DevToolsSettings -> private/reactdevtools/ReactDevToolsSett… 

    …ings

Summary:
# Changelog: [Internal]

This should not have been a public API in the first place.

1. Moving this to `src/private`.
2. Removed some unused APIs, such as profiling settings.

Differential Revision: D62965492
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    eabf16a View commit details
    Browse the repository at this point in the history

  5. fix: ReactDevToolsSettingsManagerModule in ReactModuleList for android ( 

    facebook#46665)

Summary:
Pull Request resolved: facebook#46665

# Changelog: [Internal]

Looks like this module was missing on android for a while.

Reviewed By: huntie

Differential Revision: D63460309
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fe19a13 View commit details
    Browse the repository at this point in the history