Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick: Navigator Tutorial #8756

Merged
merged 2 commits into from
Jul 13, 2016
Merged

Cherry-pick: Navigator Tutorial #8756

merged 2 commits into from
Jul 13, 2016

Conversation

JoelMarcey
Copy link

I saw no reason why we shouldn't add @hramos Navigators tutorial in the current 0.29 documentation.

@hramos @JoelMarcey
Introduce navigators in the tutorial
2f5914d 
Summary:
Adds a new section to the tutorial. Covers the basics of scenes and navigators.

The navigator comparison doc has been moved to docs/navigation.html in this PR.

![navigators](https://cloud.githubusercontent.com/assets/165856/16505919/37459e3a-3ed4-11e6-87e9-5fa7e6f792d3.png)
Closes #8515

Differential Revision: D3507325

Pulled By: caabernathy

fbshipit-source-id: e9ee5b2572868189af198cdf461b2728dfa84f9e
@hramos @JoelMarcey
Fix links from networking to navigation in The Basics.
b0ce541 
Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes #8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
@ghost
Copy link

ghost commented Jul 13, 2016

By analyzing the blame information on this pull request, we identified @hramos and @vjeux to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 13, 2016
@hramos
Copy link
Contributor

hramos commented Jul 13, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 13, 2016
@ghost
Copy link

ghost commented Jul 13, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@JoelMarcey
Copy link
Author

@hramos With cherry-picks, you just directly merge it. e.g., By pressing the Merge pull request button. :)

@JoelMarcey JoelMarcey removed the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 13, 2016
@hramos
Copy link
Contributor

hramos commented Jul 13, 2016

TIL! :)

@hramos hramos merged commit 5ffda49 into facebook:0.29-stable Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hramos hramos

@bestander bestander

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelMarcey @hramos @bestander