[React Native] Improve errors for invalid ViewConfig getter functions (…

…#16879) * [React Native] Improve logging for missing view configs and invalid view config getter functions * [React Native] Improve logging for missing view configs and invalid view config getter functions
facebook · Sep 25, 2019 · 32e5c97 · 32e5c97
1 parent ebc299f
commit 32e5c97
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 2 deletions.
diff --git a/...nderer/src/__mocks__/react-native/Libraries/ReactPrivate/ReactNativeViewConfigRegistry.js b/...nderer/src/__mocks__/react-native/Libraries/ReactPrivate/ReactNativeViewConfigRegistry.js
@@ -78,6 +78,12 @@ exports.register = function(name: string, callback: ViewConfigGetter): string {
     'Tried to register two views with the same name %s',
     name,
   );
+  invariant(
+    typeof callback === 'function',
+    'View config getter callback for component `%s` must be a function (received `%s`)',
+    name,
+    callback === null ? 'null' : typeof callback,
+  );
   viewConfigCallbacks.set(name, callback);
   return name;
 };
@@ -94,8 +100,9 @@ exports.get = function(name: string): ReactNativeBaseComponentViewConfig<> {
     if (typeof callback !== 'function') {
       invariant(
         false,
-        'View config not found for name %s.%s',
+        'View config getter callback for component `%s` must be a function (received `%s`).%s',
         name,
+        callback === null ? 'null' : typeof callback,
         typeof name[0] === 'string' && /[a-z]/.test(name[0])
           ? ' Make sure to start component names with a capital letter.'
           : '',

diff --git a/packages/react-native-renderer/src/__tests__/ReactNativeError-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactNativeError-test.internal.js
@@ -32,6 +32,18 @@ describe('ReactNativeError', () => {
         .computeComponentStackForErrorReporting;
   });
 
+  it('should throw error if null component registration getter is used', () => {
+    expect(() => {
+      try {
+        createReactNativeComponentClass('View', null);
+      } catch (e) {
+        throw new Error(e.toString());
+      }
+    }).toThrow(
+      'Invariant Violation: View config getter callback for component `View` must be a function (received `null`)',
+    );
+  });
+
   it('should be able to extract a component stack from a native view', () => {
     const View = createReactNativeComponentClass('View', () => ({
       validAttributes: {foo: true},

diff --git a/scripts/rollup/shims/react-native/ReactNativeViewConfigRegistry.js b/scripts/rollup/shims/react-native/ReactNativeViewConfigRegistry.js
@@ -75,6 +75,12 @@ exports.register = function(name: string, callback: ViewConfigGetter): string {
     'Tried to register two views with the same name %s',
     name,
   );
+  invariant(
+    typeof callback === 'function',
+    'View config getter callback for component `%s` must be a function (received `%s`)',
+    name,
+    callback === null ? 'null' : typeof callback,
+  );
   viewConfigCallbacks.set(name, callback);
   return name;
 };
@@ -91,8 +97,9 @@ exports.get = function(name: string): ReactNativeBaseComponentViewConfig<> {
     if (typeof callback !== 'function') {
       invariant(
         false,
-        'View config not found for name %s.%s',
+        'View config getter callback for component `%s` must be a function (received `%s`).%s',
         name,
+        callback === null ? 'null' : typeof callback,
         typeof name[0] === 'string' && /[a-z]/.test(name[0])
           ? ' Make sure to start component names with a capital letter.'
           : '',