[React Native] Improve errors for invalid ViewConfig getter functions #16879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew config getter functions
elicwhite
reviewed
Sep 24, 2019
| try { | ||
| createReactNativeComponentClass('View', null) | ||
| } catch (e) { | ||
| throw new Error(e.toString()); |
| } catch (e) { | ||
| throw new Error(e.toString()); | ||
| } | ||
| }).toThrow('Invariant Violation: View config getter callback must be a function: View (received null)'); |
There was a problem hiding this comment.
This doesn't read super great to me.
What about:
Invariant Violation: Cannot create component View, view config getter must be a function (received null)
There was a problem hiding this comment.
Hmm, that's reasonable but it's the registry that's throwing this error, not the createReactNativeComponentClass
There was a problem hiding this comment.
What about
'Invariant Violation: View config getter callback for component `View` must be a function (received null)'
JoshuaGross
force-pushed
the
rn-viewconfig-error-improvement
branch
2 times, most recently
from
900a6cc
to
f15d9dd
Compare
…iew config getter functions
JoshuaGross
force-pushed
the
rn-viewconfig-error-improvement
branch
from
f15d9dd
to
9eea5d5
Compare
elicwhite
approved these changes
Sep 25, 2019
rickhanlonii
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 9, 2019
…facebook#16879) * [React Native] Improve logging for missing view configs and invalid view config getter functions * [React Native] Improve logging for missing view configs and invalid view config getter functions
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 9, 2019
Summary: This diff is a partial sync of React into React Native. ## Source The source branch is from my fork [here](https://github.com/facebook/react/compare/master...rickhanlonii:react-native-partial-sync-october-9?expand=1) This branch is created from D17456249 which partially synced Dan's branch [here](facebook/react@master...gaearon:partsync). To create my branch, I forked from Dan's branch and added two commits from these PRs: - Joshua's PR to improve view config errors facebook/react#16879 - Eli's PR to remove setNativeProps warning facebook/react#17045 Reviewed By: gaearon Differential Revision: D17828989 fbshipit-source-id: 75c99737f2dec4889d7d453bbdebaeb47656b5ce
youmoxiyou
pushed a commit
to youmoxiyou/react-native
that referenced
this pull request
Oct 10, 2019
Summary: This diff is a partial sync of React into React Native. ## Source The source branch is from my fork [here](https://github.com/facebook/react/compare/master...rickhanlonii:react-native-partial-sync-october-9?expand=1) This branch is created from D17456249 which partially synced Dan's branch [here](facebook/react@master...gaearon:partsync). To create my branch, I forked from Dan's branch and added two commits from these PRs: - Joshua's PR to improve view config errors facebook/react#16879 - Eli's PR to remove setNativeProps warning facebook/react#17045 Reviewed By: gaearon Differential Revision: D17828989 fbshipit-source-id: 75c99737f2dec4889d7d453bbdebaeb47656b5ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improve error messages around invalid ViewConfig getter functions.
Details
As a followup to #16821, it is unlikely but possible for ViewConfig registry entries to be corrupted. I would like to surface this as early as possible, and include a little more information in exceptions that could be thrown later on.