Skip to content

Commit

Permalink
[Fiber] Move runWithFiberInDEV from CommitWork to CommitEffects (#30882)
Browse files Browse the repository at this point in the history
Stacked on #30881.

Move `runWithFiberInDEV` from the recursive part of the commit phase and
instead wrap each call into user space. These should really map 1:1 with
where we're using `try/catch` since that's where we're calling into user
space.

The goal of this is to avoid the extra stack frames added by
`enableOwnerStacks` in the recursive parts to avoid stack overflow. This
way we only have a couple of extra at the end of the stack instead of a
couple of extra at every depth of the tree.

DiffTrain build for commit a03254b.
  • Loading branch information
sebmarkbage committed Sep 6, 2024
1 parent d118acb commit 6f1fca9
Show file tree
Hide file tree
Showing 14 changed files with 1,911 additions and 1,775 deletions.
2 changes: 1 addition & 1 deletion compiled-rn/VERSION_NATIVE_FB
Original file line number Diff line number Diff line change
@@ -1 +1 @@
19.0.0-native-fb-fe03c56d-20240905
19.0.0-native-fb-a03254bc-20240905
Loading

0 comments on commit 6f1fca9

Please sign in to comment.