[Fizz Node] Fix null bytes written at text chunk boundaries (#26228)

We encode strings 2048 UTF-8 bytes at a time. If the string we are encoding crosses to the next chunk but the current chunk doesn't fit an integral number of characters, we need to make sure not to send the whole buffer, only the bytes that are actually meaningful. Fixes #24985. I was able to verify that this fixes the repro shared in the issue (be careful when testing because the null bytes do not show when printed to my terminal, at least). However, I don't see a clear way to add a test for this that will be resilient to small changes in how we encode the markup (since it depends on where specific multibyte characters fall against the 2048-byte boundaries). DiffTrain build for [96cdeaf](96cdeaf)
facebook · Feb 24, 2023 · a1ece33 · a1ece33
1 parent f007bf8
commit a1ece33
Show file tree

Hide file tree

Showing 28 changed files with 42 additions and 42 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-ca2cf319fdfcf6e5f048e082f5169bc1b849c129
+96cdeaf89bfde7551b4ffe4d685da169b780f2f7
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-ca2cf319fdfcf6e5f048e082f5169bc1b849c129
+96cdeaf89bfde7551b4ffe4d685da169b780f2f7
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-classic-96cdeaf89-20230224";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-modern-96cdeaf89-20230224";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-ca2cf319f-20230223";
+exports.version = "18.3.0-www-classic-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-ca2cf319f-20230223";
+exports.version = "18.3.0-www-modern-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-ca2cf319f-20230223";
+exports.version = "18.3.0-www-classic-96cdeaf89-20230224";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-ca2cf319f-20230223";
+exports.version = "18.3.0-www-modern-96cdeaf89-20230224";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-classic-96cdeaf89-20230224";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-modern-96cdeaf89-20230224";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -9786,7 +9786,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-classic-ca2cf319f-20230223",
+    version: "18.3.0-www-classic-96cdeaf89-20230224",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1301 = {
@@ -9817,7 +9817,7 @@ var internals$jscomp$inline_1301 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -9451,7 +9451,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-modern-ca2cf319f-20230223",
+    version: "18.3.0-www-modern-96cdeaf89-20230224",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1281 = {
@@ -9482,7 +9482,7 @@ var internals$jscomp$inline_1281 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -41990,7 +41990,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-classic-96cdeaf89-20230224";
 
 function createPortal$1(
   children,

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -41594,7 +41594,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-modern-96cdeaf89-20230224";
 
 function createPortal$1(
   children,

diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -15455,7 +15455,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1742 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-ca2cf319f-20230223",
+  version: "18.3.0-www-classic-96cdeaf89-20230224",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2109 = {
@@ -15485,7 +15485,7 @@ var internals$jscomp$inline_2109 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15733,4 +15733,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-ca2cf319f-20230223";
+exports.version = "18.3.0-next-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -14984,7 +14984,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1701 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-ca2cf319f-20230223",
+  version: "18.3.0-www-modern-96cdeaf89-20230224",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2073 = {
@@ -15015,7 +15015,7 @@ var internals$jscomp$inline_2073 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15192,4 +15192,4 @@ exports.unstable_flushControlled = function (fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-ca2cf319f-20230223";
+exports.version = "18.3.0-next-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -16225,7 +16225,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1822 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-ca2cf319f-20230223",
+  version: "18.3.0-www-classic-96cdeaf89-20230224",
   rendererPackageName: "react-dom"
 };
 (function (internals) {
@@ -16269,7 +16269,7 @@ var devToolsConfig$jscomp$inline_1822 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 });
 assign(Internals, {
   ReactBrowserEventEmitter: {
@@ -16504,7 +16504,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-ca2cf319f-20230223";
+exports.version = "18.3.0-next-96cdeaf89-20230224";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -15744,7 +15744,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1781 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-ca2cf319f-20230223",
+  version: "18.3.0-www-modern-96cdeaf89-20230224",
   rendererPackageName: "react-dom"
 };
 (function (internals) {
@@ -15789,7 +15789,7 @@ var devToolsConfig$jscomp$inline_1781 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function (children, container) {
@@ -15953,7 +15953,7 @@ exports.unstable_flushControlled = function (fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-ca2cf319f-20230223";
+exports.version = "18.3.0-next-96cdeaf89-20230224";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-classic-96cdeaf89-20230224";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");

diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-modern-96cdeaf89-20230224";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");

diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js
@@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-classic-ca2cf319f-20230223";
+exports.version = "18.3.0-www-classic-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/ReactDOMServer-prod.modern.js b/compiled/facebook-www/ReactDOMServer-prod.modern.js
@@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-modern-ca2cf319f-20230223";
+exports.version = "18.3.0-www-modern-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js
@@ -31227,7 +31227,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-classic-96cdeaf89-20230224";
 
 function createPortal$1(
   children,

diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js
@@ -37618,7 +37618,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-modern-96cdeaf89-20230224";
 
 function createPortal$1(
   children,

diff --git a/compiled/facebook-www/ReactDOMTesting-prod.classic.js b/compiled/facebook-www/ReactDOMTesting-prod.classic.js
@@ -11527,7 +11527,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1536 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-ca2cf319f-20230223",
+  version: "18.3.0-www-classic-96cdeaf89-20230224",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2059 = {
@@ -11557,7 +11557,7 @@ var internals$jscomp$inline_2059 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14735,4 +14735,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-ca2cf319f-20230223";
+exports.version = "18.3.0-next-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/ReactDOMTesting-prod.modern.js b/compiled/facebook-www/ReactDOMTesting-prod.modern.js
@@ -13842,7 +13842,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1653 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-ca2cf319f-20230223",
+  version: "18.3.0-www-modern-96cdeaf89-20230224",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2033 = {
@@ -13873,7 +13873,7 @@ var internals$jscomp$inline_2033 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-ca2cf319f-20230223"
+  reconcilerVersion: "18.3.0-next-96cdeaf89-20230224"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14193,4 +14193,4 @@ exports.unstable_flushControlled = function (fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-ca2cf319f-20230223";
+exports.version = "18.3.0-next-96cdeaf89-20230224";
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.classic.js b/compiled/facebook-www/ReactTestRenderer-dev.classic.js
@@ -23743,7 +23743,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-classic-96cdeaf89-20230224";
 
 // Might add PROFILE later.
 

diff --git a/compiled/facebook-www/ReactTestRenderer-dev.modern.js b/compiled/facebook-www/ReactTestRenderer-dev.modern.js
@@ -23743,7 +23743,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-ca2cf319f-20230223";
+var ReactVersion = "18.3.0-www-modern-96cdeaf89-20230224";
 
 // Might add PROFILE later.