Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Disable the "unrecognized tag" warning in React 16 but only for specific tags. #11023

Closed
ChrisRast opened this issue Oct 2, 2017 · 11 comments

Comments

@ChrisRast
Copy link

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
In Firefox the dialog element is not implemented. We use a polyfill to be able to support it. Everything works well. But React warns that the dialog element is unrecognized, and this on each page load, which is quite useless (for this specific case).
I would like the possibility to disable the warning but only for some elements. So the utility of this warning remains when the developer mistype the component name.

What is the expected behavior?
Once we specified which tag are "accepted/normal" React will not warn on specified unrecognized tags.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 16
Firefox 57

In previous versions there was no warning.

Is this clear enough? Do you need any other information?
Cheers

@gaearon
Copy link
Collaborator

gaearon commented Oct 2, 2017

We won't be making this customizable. But we're happy to take PRs that silence the warning for specific tags that are known to be on the standards track and will soon be implemented by the browsers. We already have such an exception for <time>. Would you like to send a PR?

@ChrisRast
Copy link
Author

Okay, thanks. I'll see what I can do.
But is it wise to silence dialog when we don't know when it will be implemented? The ticket tracking the issue at Mozilla is already 9 months old and it doesn't seem there's a lot of movement.

@gaearon
Copy link
Collaborator

gaearon commented Oct 2, 2017

It's in MDN and in the spec so seems like fair game. Let's add it.

@ChrisRast
Copy link
Author

I was about to start to dig in to see how I could do that. But thank you. =)
Cheers

@pgruenbacher
Copy link

what about x3dom elements?
x3dom will use a lot of custom elements to generate webgl scenes.
https://doc.x3dom.org/author/Geometry3D/BinaryGeometry.html

@gaearon
Copy link
Collaborator

gaearon commented Oct 10, 2017

Please file a new issue with an example. We could add more special cases.

@pgruenbacher
Copy link

#11184

@gaearon
Copy link
Collaborator

gaearon commented Nov 3, 2017

React 16.1.0-beta has been released. Please update react, react-dom, and react-test-renderer (if you use it) to this version and let us know if it solved the issue! We’d appreciate if you could test before Monday when we plan to get 16.1.0 out.

@lar248
Copy link

lar248 commented Dec 19, 2017

We updated our react, react-dom and react-test-renderer as suggested. We still have the issue for tspan and text - where can we find the tags that are silenced?

@gaearon
Copy link
Collaborator

gaearon commented Dec 19, 2017

Please provide a reproducing example. Maybe you're accidentally rendering them outside of SVG?

@gaearon
Copy link
Collaborator

gaearon commented Dec 19, 2017

Also, we don't track closed issues. If you have a problem please create a new one.

aepyornis added a commit to public-accountability/oligrapher that referenced this issue Feb 20, 2018
- fix graphTitle propTypes

- test for Edge.jsx show a warning relating to svg tags:
  facebook/react#11899
  facebook/react#11023

  but they still pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants