-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'tspan' and 'text' tags not working #11899
Comments
@lar248 as mentioned in #11023, can you verify if you're possibly rendering the Could you please provide a reduced test case that reproduces the issue? Thanks! |
Closing as we couldn't reproduce. If this us a problem please provide a full reproducing example. |
One other possible cause would be if |
I misunderstood @aweary’s comment: I thought he couldn’t repro with your original example. I spent a few minutes spinning up a new React project to try your original code. Unfortunately only after that I realized that the code you provided is not actually runnable as-is. You didn’t wrap the component into a Recharts container, didn’t provide the expected props, etc. I tried putting In the future, when reporting bugs, please provide examples people can actually run. If somebody goes through just ten issues, and each of those issues requires six minutes to verify before it turns out they’re unreproducible, that’s an hour spent on nothing. I very much appreciate the time you took to file the issue. But to me, it’s just sad that we could’ve fixed it but instead I have to go to other issues. Now I don’t know when I’ll be able to look into this again (assuming there’ll be a reproducing case in the future). Thank you! |
- fix graphTitle propTypes - test for Edge.jsx show a warning relating to svg tags: facebook/react#11899 facebook/react#11023 but they still pass
Do you want to request a feature or report a bug? Bug
What is the current behavior? In Chrome, we see the following errors:
Traced that this issue has persisted as seen in #11023
We have these tags capitalized already and rendered inside of the SVG, so not sure what else to do. We're using the
recharts
library as well:If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template for React 16: https://jsfiddle.net/Luktwrdm/, template for React 15: https://jsfiddle.net/hmbg7e9w/).
Here is a code snippet:
What is the expected behavior?
The expected behavior is for these charts to work without the errors in our console related to
<tspan>
or<text>
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 16.2 but this issue occurred before we updated as well
The text was updated successfully, but these errors were encountered: