Proposal of recommended config in eslint-plugin-react-hooks

[maximandrews]

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
If you are using eslint-plugin-react-hooks you need to put rules configuration manually. What if in the next version you will add some more rules?
Should everyone who use it after future release add all the new rules to config manually?

What is the expected behavior?
I propose instead of instructing on every new rule to create recommended config as in eslint-plugin-react, as follows:

export default {
  rules: {
    'rules-of-hooks': RuleOfHooks,
    'exhaustive-deps': ExhaustiveDeps
  },
  configs: {
    recommended: {
      plugins: [ 'react-hooks' ],
      parserOptions: {
        ecmaFeatures: { jsx: true }
      },
      rules: {
        'react-hooks/rules-of-hooks': 'error',
        'react-hooks/exhaustive-deps': 'warn'
      }
    }
  }
};

Also, to instruct to extend instead:

extends: [
  'eslint:recommended',
  'plugin:react/recommended',
  'plugin:react-hooks/recommended'
],

[sargant]

I would also very much like this. Is it a matter of just putting the above in a PR, or would comprehensive tests also be needed?

I'd expect the documentation should also be updated to recommend using this instead of manual rules.

[einarq]

Does anyone know why the recommendation is to set exhaustive-deps to warn instead of error?
Won't incorrect deps usually lead to stale props, missed renders, too many renders, etc?
I'm trying to make sure everyone on my team enable and follow this rule, but "warn" only helps if people actually notice. Why not recommend "error" instead?

[silvenon]

I'm also struggling to understand this decision. Not adding a dependency seems like an extremely rare situation that warrants an eslint-disable comment.

[linvain]

eslint-plugin-import does include recommended config as well:

"extends": [
  "eslint:recommended",
  "plugin:import/recommended",
  "plugin:react/recommended",
  "plugin:react-hooks/recommended" // proposal
]

[silvenon]

Actually I found out why react-hooks/exhaustive-deps is recommended as warn: because it might not always be right, i.e. might not always correctly detect all the necessary dependencies. This decision makes sense to me now.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

[stale]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!