Add recommended config for eslint-plugin-react-hooks #17976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
silvenon
force-pushed
the
eslint-plugin-react-hooks/recommended
branch
from
95c0e35
to
20ef9a7
Compare
tkovs
approved these changes
Feb 16, 2020
Now the extending `plugin:react-hooks/recommended` adds this plugin and configures both of its rules.
silvenon
force-pushed
the
eslint-plugin-react-hooks/recommended
branch
from
20ef9a7
to
6324c9f
Compare
|
Added tests. ✅ |
|
I don't think these failures are caused by my changes. 🤷♂ |
|
Just a heads up that this has already been merged in #14762 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recommended configs are a common practice with ESLint plugins, they offer a quick way to add the plugin and configure basic rules. eslint-plugin-react-hooks is especially straightforward in that regard.
With these changes extending
plugin:react-hooks/recommendedwould be equivalent to:{ "plugins": [ "react-hooks" ], "rules": { "react-hooks/rules-of-hooks": "error", "react-hooks/exhaustive-deps": "warn" } }Test Plan
I tested the config using ESLint's
CLIEngine, that seemed to strike a balance between clean and easy.Fixes #16872.