Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails on whole-document rendering #337

Closed
jordwalke opened this issue Sep 11, 2013 · 0 comments · Fixed by #339
Closed

Fails on whole-document rendering #337

jordwalke opened this issue Sep 11, 2013 · 0 comments · Fixed by #339

Comments

@jordwalke
Copy link
Contributor

See the issue reported here: 647731e

This causes react-page to fail.
@sophiebits sophiebits mentioned this issue Sep 11, 2013
Merged
@sophiebits sophiebits mentioned this issue Sep 11, 2013
Merged
sophiebits added a commit to sophiebits/react that referenced this issue Sep 11, 2013
@sophiebits
Fix full-page rendering
58fae89 
Closes facebook#337.

Test Plan:
Opened react-page sample without any JS errors. Also ran grunt test after cherry-picking this changeset on top of facebook#338.
@zpao zpao closed this as completed in #339 Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix full-page rendering sophiebits/react
1 participant
@jordwalke