Fix full-page rendering #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work if I want to full page render an iframe. Shouldn't we refer to container instead of document directly? |
Closes facebook#337. Test Plan: Opened react-page sample without any JS errors. Also ran grunt test after cherry-picking this changeset on top of facebook#338.
|
Yep, typo -- sorry. Just fixed. |
|
I like but can't merge now, @zpao if you're still on the ground I'm good for this to be merged. |
|
@spicyj: Did you test on react-page without my latest (hack) react-page commit (in |
|
Yes, I already tested that (adding a |
| @@ -235,13 +238,16 @@ var ReactMount = { | |||
| */ | |||
| prepareEnvironmentForDOM: function(container) { | |||
| invariant( | |||
| container && container.nodeType === 1, | |||
| container && ( | |||
| container.nodeType === ELEMENT_NODE_TYPE || | |||
There was a problem hiding this comment.
I didn't think of this earlier (and I'm not going to block this diff), but we should probably consider using Node.ELEMENT_NODE and Node.DOCUMENT_NODE).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337.
Test Plan:
Opened react-page sample without any JS errors. Also ran grunt test after cherry-picking this changeset on top of #338.
/cc @petehunt @jwalke