Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webcomponents example #7056

Closed
jalexanderfox opened this issue Jun 16, 2016 · 1 comment
Closed

fix webcomponents example #7056

jalexanderfox opened this issue Jun 16, 2016 · 1 comment

Comments

@jalexanderfox
Copy link
Contributor

The ReactComponent > WebComponent > ReactComponent interop example is currently partially broken:

https://github.com/facebook/react/blob/master/examples/webcomponents/index.html

In Chrome 51.x, the custom element's createdCallback

var name = this.getAttribute('name')

expect:

name === "Jim Sproch";

actual:

name === null;

To get this to work the createdCallback function can be moved to an attachedCallback.

Pull request coming soon.
jalexanderfox added a commit to jalexanderfox/react that referenced this issue Jun 16, 2016
@jalexanderfox
fix webcomponent example issue facebook#7056
93109d1
@jalexanderfox jalexanderfox mentioned this issue Jun 16, 2016
Merged
jalexanderfox added a commit to jalexanderfox/react that referenced this issue Jun 22, 2016
@jalexanderfox
update fix issue facebook#7056, remove unused web component callbacks
ec60c9c
jimfb pushed a commit that referenced this issue Jun 22, 2016
@jalexanderfox @jimfb
fix webcomponent example issue #7056 (#7057)
cd9ad90 
* fix webcomponent example issue #7056

* update fix issue #7056, remove unused web component  callbacks
@zpao
Copy link
Member

zpao commented Jul 1, 2016

Fix landed

@zpao zpao closed this as completed Jul 1, 2016
zpao pushed a commit that referenced this issue Jul 8, 2016
@jalexanderfox @zpao
fix webcomponent example issue #7056 (#7057)
ec029f6 
* fix webcomponent example issue #7056

* update fix issue #7056, remove unused web component  callbacks

(cherry picked from commit cd9ad90)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zpao @jalexanderfox