Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only public api for ReactDOMEventListener-test.js #11327

Merged
merged 6 commits into from
Nov 3, 2017
Merged

Use only public api for ReactDOMEventListener-test.js #11327

merged 6 commits into from
Nov 3, 2017

Commits on Nov 1, 2017

  1. Use only public api for ReactDOMEventListener-test.js

    @enapupe
    enapupe committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    9ad2c00 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. Merge branch 'master' into reactdom-event-listener

    @gaearon
    gaearon authored Nov 3, 2017
    Configuration menu
    Copy the full SHA
    9060cca View commit details
    Browse the repository at this point in the history

  2. Use less confusing naming 

    There was no need to extract React elements into separate variables.
    @gaearon
    gaearon authored Nov 3, 2017
    Configuration menu
    Copy the full SHA
    c84207b View commit details
    Browse the repository at this point in the history

  3. Replace the "disappearance" test 

    I could not get it to fail on master so it was probably testing something specific to Stack implementation details. It was also already broken because it didn't look at the right argument and never actually called `unmountComponentAtNode`.

Instead I replaced it with original repro case from #1105 which is when it was introduced.
    @gaearon
    gaearon authored Nov 3, 2017
    Configuration menu
    Copy the full SHA
    50c74a9 View commit details
    Browse the repository at this point in the history

  4. Tweak naming and add comments

    @gaearon
    gaearon authored Nov 3, 2017
    Configuration menu
    Copy the full SHA
    d188ba0 View commit details
    Browse the repository at this point in the history

  5. Missed this one

    @gaearon
    gaearon authored Nov 3, 2017
    Configuration menu
    Copy the full SHA
    e11af09 View commit details
    Browse the repository at this point in the history