Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SVG ellipse elements. #1675

Closed
wants to merge 1 commit into from

Conversation

brandonbloom
Copy link
Contributor

No description provided.

brandonbloom added a commit to brandonbloom/react that referenced this pull request Jun 11, 2014
@brandonbloom
Copy link
Contributor Author

D'oh! Will update docs.

@brandonbloom
Copy link
Contributor Author

Updated.

@sophiebits
Copy link
Collaborator

Can you update the list in vendor/fbtransform/transforms/xjs.js too?

@brandonbloom
Copy link
Contributor Author

@sophiebits
Copy link
Collaborator

So it is!

@brandonbloom
Copy link
Contributor Author

I'm not readily able to interpret those failing CI results. Please let me know if action on my part is necessary.

@sophiebits
Copy link
Collaborator

Should be good. I reran the build and it passed this time:

https://travis-ci.org/facebook/react/jobs/27331192

@jonase
Copy link
Contributor

jonase commented Jun 15, 2014

See also #1657

@zpao zpao closed this in aebb326 Jun 20, 2014
@zpao
Copy link
Member

zpao commented Jun 20, 2014

Thanks Brandon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants