Add support for SVG marker element #1769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added attributes required to get the example at https://developer.mozilla.org/en-US/docs/Web/SVG/Element/marker working correctly |
|
👍 This would be very helpful. |
|
+1 |
|
It seems this issue became obsolete before merging. I have created a new PR #5398. |
|
Thank you for the PR, and sorry about the long wait. Now that #5714 is merged, all attributes on SVG elements will be passed through as is, with no need for the whitelist. I'm closing this but please let me know if you have any troubles in master. |
This was referenced Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the SVG marker element as mentioned in #1657 (comment). I followed @brandonbloom's patch where he added support for the ellipse element