Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop exposing some internals on FB build #18011

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 10, 2020

These are no longer used. Test plan: tbgs.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 10, 2020
@sizebot
Copy link

sizebot commented Feb 10, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against e0f4c50

@sizebot
Copy link

sizebot commented Feb 10, 2020

Details of bundled changes.

Comparing: 517de74...e0f4c50

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 711 B 709 B UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.21 KB 11.21 KB 4.17 KB 4.17 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.66 KB 53.66 KB 15.27 KB 15.27 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.93 KB 60.93 KB 16.08 KB 16.08 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 698 B 697 B NODE_PROD
ReactDOM-dev.js -0.0% +0.1% 986.73 KB 986.59 KB 218.2 KB 218.32 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
ReactDOM-prod.js -0.1% -0.0% 393.59 KB 393.39 KB 71.93 KB 71.92 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% -0.0% 404.84 KB 404.64 KB 74.09 KB 74.08 KB FB_WWW_PROFILING
react-dom-testing.profiling.min.js 0.0% -0.0% 121.12 KB 121.12 KB 39.04 KB 39.04 KB UMD_PROFILING
react-dom-testing.development.js 0.0% 0.0% 956.65 KB 956.65 KB 214.4 KB 214.4 KB NODE_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 985.25 KB 985.25 KB 217.47 KB 217.47 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: -0.3%

Size changes (experimental)

Generated by 🚫 dangerJS against e0f4c50

@gaearon gaearon merged commit ab7b83a into facebook:master Feb 10, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0f4c50:

Sandbox Source
pensive-waterfall-b66i4 Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants