Move getIsHydrating from FB fork to Experimental flag #18012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a73fbc3:
|
sebmarkbage
requested changes
Feb 10, 2020
| @@ -179,6 +180,8 @@ if (exposeConcurrentModeAPIs) { | |||
| queueExplicitHydrationTarget(target); | |||
| } | |||
| }; | |||
|
|
|||
| ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.getIsHydrating = getIsHydrating; | |||
There was a problem hiding this comment.
It's very important that this isn't exposed in the CM release. It won't be needed by the future API neither.
Instead, put it behind a specific feature flag that we won't enable.
|
Ahh I thought this was for hero tracing or something like this. Okay I'll disable and just remove this. |
Merged
|
Ain't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no actual impact except that getIsHydrating is on the secrets object for everyone, and not just FB. This would let us completely get rid of the forked FB-specific entry point in the modern version. Instead of the forked entry point, we will use feature flags to remove individual features.