Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getIsHydrating #18019

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Remove getIsHydrating #18019

merged 1 commit into from
Feb 12, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 11, 2020

It's not needed after D19837930.
Alternative to #18012.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Feb 11, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ce4e96:

Sandbox Source
lingering-tree-nx1by Configuration

@sizebot
Copy link

sizebot commented Feb 11, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 2ce4e96

@sizebot
Copy link

sizebot commented Feb 11, 2020

Details of bundled changes.

Comparing: f727803...2ce4e96

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.87 KB 123.87 KB 38.77 KB 38.77 KB NODE_PROFILING
ReactDOMServer-prod.js 0.0% 0.0% 48.99 KB 48.99 KB 11.18 KB 11.18 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-test-utils.development.js 0.0% -0.0% 55.39 KB 55.39 KB 15.6 KB 15.59 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.42 KB 121.42 KB 38.35 KB 38.35 KB NODE_PROFILING
ReactDOMTesting-prod.js 0.0% -0.0% 341.24 KB 341.24 KB 62.28 KB 62.28 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 139.32 KB 139.32 KB 36.94 KB 36.94 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.21 KB 11.21 KB 4.17 KB 4.17 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.46 KB 20.46 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.66 KB 53.66 KB 15.27 KB 15.27 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 135.26 KB 135.26 KB 35.92 KB 35.92 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD
react-dom.development.js 0.0% -0.0% 968.93 KB 968.93 KB 217.71 KB 217.71 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.93 KB 60.93 KB 16.08 KB 16.08 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 120 KB 120 KB 38.39 KB 38.39 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 123.63 KB 123.63 KB 39.58 KB 39.59 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 963.01 KB 963.01 KB 216.04 KB 216.04 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.63 KB 60.63 KB 16 KB 16 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.99 KB 9.99 KB 3.38 KB 3.38 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 140.41 KB 140.41 KB 35.54 KB 35.54 KB FB_WWW_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 698 B 697 B NODE_PROD
ReactDOM-dev.js -0.0% -0.2% 990.36 KB 990.33 KB 218.95 KB 218.5 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% -0.5% 395.74 KB 395.6 KB 72.29 KB 71.89 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% -0.0% 966.35 KB 966.35 KB 216.73 KB 216.73 KB UMD_DEV
ReactDOM-profiling.js -0.0% -0.6% 407.08 KB 406.93 KB 74.44 KB 73.98 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 136.37 KB 136.37 KB 36.15 KB 36.15 KB NODE_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against 2ce4e96

@gaearon gaearon merged commit a607ea4 into facebook:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants