Fix act bundle size regression
#19832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds back the `TestUtils.act` implementation that I had removed in facebook#19745. This version of `act` is implemented in "userspace" (i.e. not the reconciler), so it doesn't add to the production bundle size. I had removed this in facebook#19745 in favor of the `act` exported by the reconciler because I thought we would remove support for `act` in production in the impending major release. (It currently warns.) However, we've since decided to continue supporting `act` in prod for now, so that it doesn't block people from upgrading to v17. We'll drop support in a future major release. So, to avoid bloating the production bundle size, we need to move the public version of `act` back to "userspace", like it was before. This doesn't negate the main goal of facebook#19745, though, which was to decouple the public version(s) of `act` from the internal one that we use to test React itself.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62105de:
|
Details of bundled changes.Comparing: ec39a5e...62105de react-dom
ReactDOM: size: 🔺+6.4%, gzip: 🔺+5.8% Size changes (experimental) |
Details of bundled changes.Comparing: ec39a5e...62105de react-dom
ReactDOM: size: 🔺+6.4%, gzip: 🔺+5.8% Size changes (stable) |
|
Confirmed this fixes the size regression. sizebot comment is misleading :D TestUtils bundle increased (as expected), but the React DOM bundle size decreased.
|
rickhanlonii
approved these changes
Sep 14, 2020
todortotev
pushed a commit
to todortotev/react
that referenced
this pull request
Sep 18, 2020
Adds back the `TestUtils.act` implementation that I had removed in facebook#19745. This version of `act` is implemented in "userspace" (i.e. not the reconciler), so it doesn't add to the production bundle size. I had removed this in facebook#19745 in favor of the `act` exported by the reconciler because I thought we would remove support for `act` in production in the impending major release. (It currently warns.) However, we've since decided to continue supporting `act` in prod for now, so that it doesn't block people from upgrading to v17. We'll drop support in a future major release. So, to avoid bloating the production bundle size, we need to move the public version of `act` back to "userspace", like it was before. This doesn't negate the main goal of facebook#19745, though, which was to decouple the public version(s) of `act` from the internal one that we use to test React itself.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Adds back the `TestUtils.act` implementation that I had removed in facebook#19745. This version of `act` is implemented in "userspace" (i.e. not the reconciler), so it doesn't add to the production bundle size. I had removed this in facebook#19745 in favor of the `act` exported by the reconciler because I thought we would remove support for `act` in production in the impending major release. (It currently warns.) However, we've since decided to continue supporting `act` in prod for now, so that it doesn't block people from upgrading to v17. We'll drop support in a future major release. So, to avoid bloating the production bundle size, we need to move the public version of `act` back to "userspace", like it was before. This doesn't negate the main goal of facebook#19745, though, which was to decouple the public version(s) of `act` from the internal one that we use to test React itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back the
TestUtils.actimplementation that I had removed in #19745. This version ofactis implemented in "userspace" (i.e. not the reconciler), so it doesn't add to the production bundle size.I had removed this in #19745 in favor of the
actexported by the reconciler because I thought we would remove support foractin production in the impending major release. (It currently warns.)However, we've since decided to continue supporting
actin prod for now, so that it doesn't block people from upgrading to v17. We'll drop support in a future major release.So, to avoid bloating the production bundle size, we need to move the public version of
actback to "userspace", like it was before.This doesn't negate the main goal of #19745, though, which was to decouple the public version(s) of
actfrom the internal one that we use to test React itself.