Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix act bundle size regression #19832

Merged
merged 1 commit into from
Sep 14, 2020

Commits on Sep 14, 2020

  1. Fix act bundle size regression

    Adds back the `TestUtils.act` implementation that I had removed
    in facebook#19745. This version of `act` is implemented in "userspace" (i.e. not
    the reconciler), so it doesn't add to the production bundle size.
    
    I had removed this in facebook#19745 in favor of the `act` exported by the
    reconciler because I thought we would remove support for `act` in
    production in the impending major release. (It currently warns.)
    
    However, we've since decided to continue supporting `act` in prod for
    now, so that it doesn't block people from upgrading to v17. We'll drop
    support in a future major release.
    
    So, to avoid bloating the production bundle size, we need to move the
    public version of `act` back to "userspace", like it was before.
    
    This doesn't negate the main goal of facebook#19745, though, which was to
    decouple the public version(s) of `act` from the internal one that we
    use to test React itself.
    acdlite committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    62105de View commit details
    Browse the repository at this point in the history