Remove unstable_changedBits #20953
Merged
Remove unstable_changedBits #20953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added this unstable feature a few years ago, as a way to opt out of context updates, but it didn't prove useful in practice. We have other proposals for how to address the same problem, like context selectors. Since it was prefixed with `unstable_`, we should be able to remove it without consequence. The hook API already warned if you used it. Even if someone is using it somewhere, it's meant to be an optimization only, so if they are using the API properly, it should not have any semantic impact.
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
commented
Mar 8, 2021
| @@ -590,227 +561,6 @@ describe('ReactNewContext', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| it('can skip consumers with bitmask', () => { | |||
There was a problem hiding this comment.
These have corresponding tests in the context selectors PR
|
Comparing: 5fe091c...efad8ac Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
force-pushed
the
remove-changedbits
branch
4 times, most recently
from
6c4d404
to
efad8ac
Compare
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Mar 23, 2021
We added this unstable feature a few years ago, as a way to opt out of context updates, but it didn't prove useful in practice. We have other proposals for how to address the same problem, like context selectors. Since it was prefixed with `unstable_`, we should be able to remove it without consequence. The hook API already warned if you used it. Even if someone is using it somewhere, it's meant to be an optimization only, so if they are using the API properly, it should not have any semantic impact.
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 23, 2021
Summary: This sync includes the following changes: - **[6d3ecb70d](facebook/react@6d3ecb70d )**: Remove unstable_changedBits ([#20953](facebook/react#20953)) //<Andrew Clark>// - **[754e30728](facebook/react@754e30728 )**: Delete immediateQueueCallbackNode ([#20980](facebook/react#20980)) //<Andrew Clark>// - **[be5a2e231](facebook/react@be5a2e231 )**: Land enableSyncMicrotasks ([#20979](facebook/react#20979)) //<Andrew Clark>// - **[f6bc9c824](facebook/react@f6bc9c824 )**: [Fizz] Expose maxBoundarySize as an option ([#21029](facebook/react#21029)) //<Sebastian Markbåge>// - **[154b85213](facebook/react@154b85213 )**: [Fizz] Expose a method to explicitly start writing to a Node stream ([#21028](facebook/react#21028)) //<Sebastian Markbåge>// - **[cf485e6f6](facebook/react@cf485e6f6 )**: [Fizz] Expose a method to abort a pending request ([#21027](facebook/react#21027)) //<Sebastian Markbåge>// - **[3fb11eed9](facebook/react@3fb11eed9 )**: React Native: Touch Instrumentation Interface ([#21024](facebook/react#21024)) //<Timothy Yung>// - **[825c3021f](facebook/react@825c3021f )**: Don't delete trailing mismatches during hydration at the root ([#21021](facebook/react#21021)) //<Sebastian Markbåge>// - **[1d1e49cfa](facebook/react@1d1e49cfa )**: [Fizz] Assign an ID to the first DOM element in a fallback or insert a dummy (and testing infra) ([#21020](facebook/react#21020)) //<Sebastian Markbåge>// - **[466b26c92](facebook/react@466b26c92 )**: Store commit durations on HostRoot for DevTools access ([#20983](facebook/react#20983)) //<Brian Vaughn>// - **[89acfa639](facebook/react@89acfa639 )**: Fix native event batching in concurrent mode ([#21010](facebook/react#21010)) //<Ricky>// - **[0203b6567](facebook/react@0203b6567 )**: chore: update react-reconciler README ([#21016](facebook/react#21016)) //<susiwen8>// Changelog: [General][Changed] - React Native sync for revisions c9f6d0a...6d3ecb7 jest_e2e[run_all_tests] Reviewed By: JoshuaGross, kacieb Differential Revision: D27231625 fbshipit-source-id: 89c0c0662e69044ae8890486a693013bee6005dd
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
We added this unstable feature a few years ago, as a way to opt out of context updates, but it didn't prove useful in practice. We have other proposals for how to address the same problem, like context selectors. Since it was prefixed with `unstable_`, we should be able to remove it without consequence. The hook API already warned if you used it. Even if someone is using it somewhere, it's meant to be an optimization only, so if they are using the API properly, it should not have any semantic impact.
|
Hey there! The use-context-selection used the I completely understand the feature was marked as unstable and thereby there were risk for it to be removed. This comment is just to ask/check if there is a 1:1 replacement I could use/explore to support a similar behavior and integrate in the mentioned library (?) Otherwise, I think I'll update the library Readme to make it clear this won't work for React >= 18, and probably suggest opting for https://github.com/dai-shi/use-context-selector instead Thanks in advance for any help! |
|
Sorry, there is no 1:1 replacement. There's been initial work on #20646, but it is currently paused. |
JinmuGo
added a commit
to 42ForYou/RFS
that referenced
this pull request
Mar 17, 2024
changedBits 삭제 facebook/react#20953
JinmuGo
added a commit
to 42ForYou/RFS
that referenced
this pull request
Mar 17, 2024
* FY-215/perf(changedBits): remove changedBits 삭제 facebook/react#20953 * FY-215/refactor: remove threadcount * FY-215/refactor: remove rendererSigil * FY-215/refactor: project * FY-215/refactor: remain observedBits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this unstable feature a few years ago, as a way to opt out of context updates, but it didn't prove useful in practice.
We have other proposals for how to address the same problem, like context selectors.
Since it was prefixed with
unstable_, we should be able to remove it without consequence. The hook API already warned if you used it.Even if someone is using it somewhere, it's meant to be an optimization only, so if they are using the API properly, it should not have any semantic impact.