Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land enableSyncMicrotasks #20979

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 11, 2021

No description provided.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Mar 11, 2021
@sizebot
Copy link

sizebot commented Mar 11, 2021

Comparing: f6bc9c8...b729510

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.12% 122.89 kB 123.03 kB +0.16% 39.55 kB 39.62 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.11% 129.38 kB 129.53 kB +0.11% 41.61 kB 41.66 kB
facebook-www/ReactDOM-prod.classic.js = 409.01 kB 408.59 kB = 75.85 kB 75.75 kB
facebook-www/ReactDOM-prod.modern.js = 397.27 kB 396.84 kB = 73.91 kB 73.81 kB
facebook-www/ReactDOMForked-prod.classic.js = 409.02 kB 408.60 kB = 75.85 kB 75.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/SchedulerTracing-dev.classic.js = 11.11 kB 11.04 kB = 2.44 kB 2.43 kB
facebook-www/SchedulerTracing-dev.modern.js = 11.11 kB 11.04 kB = 2.44 kB 2.43 kB
facebook-www/ReactIs-dev.modern.js = 10.08 kB 10.01 kB = 2.72 kB 2.70 kB
facebook-www/ReactIs-dev.classic.js = 9.81 kB 9.75 kB = 2.67 kB 2.65 kB

Generated by 🚫 dangerJS against b729510

@acdlite
Copy link
Collaborator Author

acdlite commented Mar 11, 2021

Ah, the tests fail when disableSchedulerTimeoutInWorkLoop is off

@acdlite acdlite marked this pull request as draft March 11, 2021 08:17
@acdlite acdlite force-pushed the land-enablesyncmicrotasks branch 3 times, most recently from eb5a417 to b729510 Compare March 19, 2021 22:16
@acdlite acdlite marked this pull request as ready for review March 19, 2021 22:21
@acdlite
Copy link
Collaborator Author

acdlite commented Mar 19, 2021

Landing as part of #20980 series

@acdlite acdlite merged commit be5a2e2 into facebook:master Mar 19, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Mar 23, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Mar 23, 2021
Summary:
This sync includes the following changes:
- **[6d3ecb70d](facebook/react@6d3ecb70d )**: Remove unstable_changedBits ([#20953](facebook/react#20953)) //<Andrew Clark>//
- **[754e30728](facebook/react@754e30728 )**: Delete immediateQueueCallbackNode ([#20980](facebook/react#20980)) //<Andrew Clark>//
- **[be5a2e231](facebook/react@be5a2e231 )**: Land enableSyncMicrotasks ([#20979](facebook/react#20979)) //<Andrew Clark>//
- **[f6bc9c824](facebook/react@f6bc9c824 )**: [Fizz] Expose maxBoundarySize as an option ([#21029](facebook/react#21029)) //<Sebastian Markbåge>//
- **[154b85213](facebook/react@154b85213 )**: [Fizz] Expose a method to explicitly start writing to a Node stream ([#21028](facebook/react#21028)) //<Sebastian Markbåge>//
- **[cf485e6f6](facebook/react@cf485e6f6 )**: [Fizz] Expose a method to abort a pending request ([#21027](facebook/react#21027)) //<Sebastian Markbåge>//
- **[3fb11eed9](facebook/react@3fb11eed9 )**: React Native: Touch Instrumentation Interface ([#21024](facebook/react#21024)) //<Timothy Yung>//
- **[825c3021f](facebook/react@825c3021f )**: Don't delete trailing mismatches during hydration at the root ([#21021](facebook/react#21021)) //<Sebastian Markbåge>//
- **[1d1e49cfa](facebook/react@1d1e49cfa )**: [Fizz] Assign an ID to the first DOM element in a fallback or insert a dummy (and testing infra) ([#21020](facebook/react#21020)) //<Sebastian Markbåge>//
- **[466b26c92](facebook/react@466b26c92 )**: Store commit durations on HostRoot for DevTools access ([#20983](facebook/react#20983)) //<Brian Vaughn>//
- **[89acfa639](facebook/react@89acfa639 )**: Fix native event batching in concurrent mode ([#21010](facebook/react#21010)) //<Ricky>//
- **[0203b6567](facebook/react@0203b6567 )**: chore: update react-reconciler README ([#21016](facebook/react#21016)) //<susiwen8>//

Changelog:
[General][Changed] - React Native sync for revisions c9f6d0a...6d3ecb7

jest_e2e[run_all_tests]

Reviewed By: JoshuaGross, kacieb

Differential Revision: D27231625

fbshipit-source-id: 89c0c0662e69044ae8890486a693013bee6005dd
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants