Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Event priority of passive effect phase should not be higher than default #21215

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix: Event priority of passive effect phase should not be higher than default #21215

merged 1 commit into from
Apr 9, 2021
+101 −10

Commits on Apr 9, 2021

  1. Fix: Passive effect updates are never sync 

    I screwed this up in facebook#21082. Got confused by the < versus > thing again.

The helper functions are annoying, too, because I always forget the
intended order of the arguments. But they're still helpful because when
we refactor the type we only have the change the logic in one place.

Added a regression test.
    @acdlite
    acdlite committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    da6eaf7 View commit details
    Browse the repository at this point in the history