Add hook warning when going to/from 0 hooks #24535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
May 10, 2022
packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js
Show resolved
Hide resolved
This was referenced May 10, 2022
|
Comparing: 229c86a...b5e48aa Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
This actually makes it throw, right? Not just a warning. So this would hard-break the code that currently (accidentally) relies on this. I was thinking we'd do it the opposite way instead. I.e. fix the warning first to always show up. And later make it throw consistently after people have had a chance to fix the warnings. |
rickhanlonii
force-pushed
the
rh-hook-warn
branch
from
7cc97ff
to
03f1089
Compare
|
@gaearon that makes sense, I can update that. |
gaearon
reviewed
May 12, 2022
acdlite
reviewed
May 13, 2022
rickhanlonii
force-pushed
the
rh-hook-warn
branch
from
4f4fc4e
to
23a3ad7
Compare
|
Ok I've updated the logic here such that:
|
rickhanlonii
force-pushed
the
rh-hook-warn
branch
5 times, most recently
from
6e92003
to
4b511ab
Compare
rickhanlonii
force-pushed
the
rh-hook-warn
branch
from
4b511ab
to
b5e48aa
Compare
rickhanlonii
commented
Jun 16, 2022
| @@ -478,11 +521,25 @@ export function renderWithHooks<Props, SecondArg>( | |||
| ReactCurrentDispatcher.current = ContextOnlyDispatcher; | |||
|
|
|||
| if (__DEV__) { | |||
| if ( | |||
There was a problem hiding this comment.
Calling this out - this isn't pretty but it adds the warning for going from some hooks to no hooks.
| 'Rendered fewer hooks than expected. This may be caused by an ' + | ||
| 'accidental early return statement.', | ||
| ); | ||
| }).toErrorDev([ |
There was a problem hiding this comment.
This is the warning the not pretty code mentioned above adds. As well as the "unmount effect" test below.
| 'Rendered fewer hooks than expected. This may be caused by an ' + | ||
| 'accidental early return statement.', | ||
| ); | ||
| }).toErrorDev([ |
There was a problem hiding this comment.
This is the warning the not pretty code mentioned above adds. As well as the "unmount effect" test below.
|
Replaced by: #25216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a hook warning for when we go from 0 to n > 0 hooks or from n > 0 to 0 hooks in a component, such as using an early return like:
We only add this warning in the new root, since the blocker to this in legacy mode was a quirk with React.lazy not applicable in the new root.