Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when going to/from 0 hook #25216

Closed
wants to merge 4 commits into from
Closed

Conversation

tyao1
Copy link
Contributor

@tyao1 tyao1 commented Sep 9, 2022

Summary

For fixing #24438.

How did you test this change?

yarn test --watch ReactHooksWithnoopRenderer (--variant=true/false)
yarn test --prod
CI jobs

@tyao1 tyao1 requested a review from acdlite September 9, 2022 06:11
@tyao1 tyao1 marked this pull request as draft September 9, 2022 06:11
@sizebot
Copy link

sizebot commented Sep 9, 2022

Comparing: c80e541...e544013

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 134.97 kB 134.97 kB = 43.23 kB 43.23 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 141.69 kB 141.69 kB = 45.23 kB 45.22 kB
facebook-www/ReactDOM-prod.classic.js +0.04% 486.24 kB 486.41 kB +0.06% 86.55 kB 86.60 kB
facebook-www/ReactDOM-prod.modern.js +0.04% 471.52 kB 471.69 kB +0.07% 84.32 kB 84.38 kB
facebook-www/ReactDOMForked-prod.classic.js +0.04% 486.24 kB 486.41 kB +0.06% 86.55 kB 86.60 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-dev.modern.js +1.01% 9.62 kB 9.72 kB +0.75% 2.54 kB 2.56 kB
facebook-www/ReactIs-dev.classic.js +1.01% 9.62 kB 9.72 kB +0.75% 2.54 kB 2.56 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.21% 45.70 kB 45.80 kB +0.19% 12.94 kB 12.96 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.21% 45.70 kB 45.80 kB +0.20% 12.94 kB 12.96 kB

Generated by 🚫 dangerJS against e544013

Copy link

@nuhmanpk nuhmanpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@gaearon
Copy link
Collaborator

gaearon commented Sep 9, 2022

Does this supersede #24535?

@tyao1
Copy link
Contributor Author

tyao1 commented Sep 9, 2022

Does this supersede #24535?

Yeah

@tyao1 tyao1 changed the title [WIP] Warn when going to/from 0 hook Warn when going to/from 0 hook Sep 9, 2022
@tyao1 tyao1 marked this pull request as ready for review September 9, 2022 22:03
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants