[tests] Assert scheduler log empty in internalAct #28737

rickhanlonii · 2024-04-03T21:54:32Z

We should force assertLog to be called before each act block to ensure the queue is empty.

Requires fixing tests:

react-sizebot · 2024-04-03T21:58:17Z

Comparing: 870e404...66f4133

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	168.12 kB	168.12 kB	=	52.72 kB	52.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	169.92 kB	169.92 kB	=	53.26 kB	53.26 kB
facebook-www/ReactDOM-prod.classic.js	=	588.50 kB	588.50 kB	=	103.50 kB	103.50 kB
facebook-www/ReactDOM-prod.modern.js	=	564.35 kB	564.35 kB	=	99.66 kB	99.66 kB
test_utils/ReactAllWarnings.js	Deleted	64.24 kB	0.00 kB	Deleted	16.03 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	64.24 kB	0.00 kB	Deleted	16.03 kB	0.00 kB

Generated by 🚫 dangerJS against 66f4133

Fixes some easy cases blocking #28737, I'll follow up with more complex/interesting cases in other PRs.

Fixes tests blocking #28737

) Fixes tests blocking #28737

Fixes tests blocking #28737

These test don't `assertLog` or `waitFor` so we don't need to `Scheduler.log`. Ideally we would, but since they're fuzzers it's a bit difficult to know what the expected log is from the helper. Since this doesn't regress current test behavior, we can improve them after this to unblock #28737

A few more tests for #28737

Fixes tests blocking #28737

These test don't `assertLog` or `waitFor` so we don't need to `Scheduler.log`. Ideally we would, but since they're fuzzers it's a bit difficult to know what the expected log is from the helper. Since this doesn't regress current test behavior, we can improve them after this to unblock #28737

A few more tests for #28737

We should force `assertLog` to be called before each `act` block to ensure the queue is empty. Requires fixing tests: - #28745 - #28758 - #28759 - #28760 - #28761 - #28762 - #28763 - #28812

Fixes some easy cases blocking #28737, I'll follow up with more complex/interesting cases in other PRs.

Fixes tests blocking #28737

) Fixes tests blocking #28737

Fixes tests blocking #28737

These test don't `assertLog` or `waitFor` so we don't need to `Scheduler.log`. Ideally we would, but since they're fuzzers it's a bit difficult to know what the expected log is from the helper. Since this doesn't regress current test behavior, we can improve them after this to unblock #28737

A few more tests for #28737

We should force `assertLog` to be called before each `act` block to ensure the queue is empty. Requires fixing tests: - #28745 - #28758 - #28759 - #28760 - #28761 - #28762 - #28763 - #28812

Fixes some easy cases blocking facebook#28737, I'll follow up with more complex/interesting cases in other PRs.

…k#28758) Fixes tests blocking facebook#28737

…ebook#28759) Fixes tests blocking facebook#28737

Fixes tests blocking facebook#28737

These test don't `assertLog` or `waitFor` so we don't need to `Scheduler.log`. Ideally we would, but since they're fuzzers it's a bit difficult to know what the expected log is from the helper. Since this doesn't regress current test behavior, we can improve them after this to unblock facebook#28737

A few more tests for facebook#28737

We should force `assertLog` to be called before each `act` block to ensure the queue is empty. Requires fixing tests: - facebook#28745 - facebook#28758 - facebook#28759 - facebook#28760 - facebook#28761 - facebook#28762 - facebook#28763 - facebook#28812

Summary: This sync includes the changes from: - D56103750 - [TODO] A shim for SECRET_INTERNALS This sync includes the following changes: - **[b5e5ce8e0](facebook/react@b5e5ce8e0 )**: Update ReactNativeTypes for root options (part 2) ([#28857](facebook/react#28857)) //<Ricky>// - **[da6ba53b1](facebook/react@da6ba53b1 )**: [UMD] Remove umd builds ([#28735](facebook/react#28735)) //<Josh Story>// - **[0c245df1d](facebook/react@0c245df1d )**: Complete the typo fix ([#28856](facebook/react#28856)) //<Sebastian Silbermann>// - **[f82051d7a](facebook/react@f82051d7a )**: console test utils fix: match entire string, not just first letter ([#28855](facebook/react#28855)) //<Andrew Clark>// - **[4ca20fd36](facebook/react@4ca20fd36 )**: Test top level fragment inside lazy semantics ([#28852](facebook/react#28852)) //<Sebastian Markbåge>// - **[c0cf7c696](facebook/react@c0cf7c696 )**: Promote ASYNC_ITERATOR symbol to React Symbols ([#28851](facebook/react#28851)) //<Sebastian Markbåge>// - **[657428a9e](facebook/react@657428a9e )**: Add ReactNativeTypes for root options ([#28850](facebook/react#28850)) //<Ricky>// - **[7909d8eab](facebook/react@7909d8eab )**: [Flight] Encode ReadableStream and AsyncIterables ([#28847](facebook/react#28847)) //<Sebastian Markbåge>// - **[13eb61d05](facebook/react@13eb61d05 )**: Move enableUseDeferredValueInitialArg to canary ([#28818](facebook/react#28818)) //<Andrew Clark>// - **[8afa144bd](facebook/react@8afa144bd )**: Enable flag disableClientCache ([#28846](facebook/react#28846)) //<Jan Kassens>// - **[734956ace](facebook/react@734956ace )**: Devtools: Add support for useFormStatus ([#28413](facebook/react#28413)) //<Sebastian Silbermann>// - **[17e920c00](facebook/react@17e920c00 )**: [Flight Reply] Encode Typed Arrays and Blobs ([#28819](facebook/react#28819)) //<Sebastian Markbåge>// - **[0347fcd00](facebook/react@0347fcd00 )**: Add on(Caught|Uncaught|Recoverable) opts to RN ([#28836](facebook/react#28836)) //<Ricky>// - **[c113503ad](facebook/react@c113503ad )**: Flush direct streams in Bun ([#28837](facebook/react#28837)) //<Kenta Iwasaki>// - **[9defcd56b](facebook/react@9defcd56b )**: Remove redundant props assign ([#28829](facebook/react#28829)) //<Sebastian Silbermann>// - **[ed4023603](facebook/react@ed4023603 )**: Fix mistaken "react-server" condition ([#28835](facebook/react#28835)) //<Sebastian Markbåge>// - **[c8a035036](facebook/react@c8a035036 )**: [Fizz] hoistables should never flush before the preamble ([#28802](facebook/react#28802)) //<Josh Story>// - **[4f5c812a3](facebook/react@4f5c812a3 )**: DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions ([#28593](facebook/react#28593)) //<Sebastian Silbermann>// - **[435415962](facebook/react@435415962 )**: Backwards compatibility for string refs on WWW ([#28826](facebook/react#28826)) //<Jack Pope>// - **[608edcc90](facebook/react@608edcc90 )**: [tests] add `assertConsole<method>Dev` helpers ([#28732](facebook/react#28732)) //<Ricky>// - **[da69b6af9](facebook/react@da69b6af9 )**: ReactDOM.requestFormReset ([#28809](facebook/react#28809)) //<Andrew Clark>// - **[374b5d26c](facebook/react@374b5d26c )**: Scaffolding for requestFormReset API ([#28808](facebook/react#28808)) //<Andrew Clark>// - **[41950d14a](facebook/react@41950d14a )**: Automatically reset forms after action finishes ([#28804](facebook/react#28804)) //<Andrew Clark>// - **[dc6a7e01e](facebook/react@dc6a7e01e )**: [Float] Don't preload images inside `<noscript>` ([#28815](facebook/react#28815)) //<Josh Story>// - **[3f947b1b4](facebook/react@3f947b1b4 )**: [tests] Assert scheduler log empty in internalAct ([#28737](facebook/react#28737)) //<Ricky>// - **[bf09089f6](facebook/react@bf09089f6 )**: Remove Scheduler.log from ReactSuspenseFuzz-test ([#28812](facebook/react#28812)) //<Ricky>// - **[84cb3b4cb](facebook/react@84cb3b4cb )**: Hardcode disableIEWorkarounds for www ([#28811](facebook/react#28811)) //<Ricky>// - **[2243b40ab](facebook/react@2243b40ab )**: [tests] assertLog before act in useEffectEvent ([#28763](facebook/react#28763)) //<Ricky>// - **[dfc64c6e3](facebook/react@dfc64c6e3 )**: [tests] assertLog before act in ReactUse ([#28762](facebook/react#28762)) //<Ricky>// - **[42eff4bc7](facebook/react@42eff4bc7 )**: [tests] Fix assertions not flushed before act ([#28745](facebook/react#28745)) //<Ricky>// - **[ed3c65caf](facebook/react@ed3c65caf )**: Warn if outdated JSX transform is detected ([#28781](facebook/react#28781)) //<Andrew Clark>// - **[3f9e237a2](facebook/react@3f9e237a2 )**: Fix: Suspend while recovering from hydration error ([#28800](facebook/react#28800)) //<Andrew Clark>// - **[7f5d25e23](facebook/react@7f5d25e23 )**: Fix cloneElement using string ref w no owner ([#28797](facebook/react#28797)) //<Joseph Savona>// - **[bf40b0244](facebook/react@bf40b0244 )**: [Fizz] Stop publishing external-runtime to stable channel ([#28796](facebook/react#28796)) //<Josh Story>// - **[7f93cb41c](facebook/react@7f93cb41c )**: [DOM] Infer react-server entries bundles if not explicitly configured ([#28795](facebook/react#28795)) //<Josh Story>// - **[f61316535](facebook/react@f61316535 )**: Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([#28789](facebook/react#28789)) //<Sebastian Markbåge>// - **[9644d206e](facebook/react@9644d206e )**: Soften useFormState warning ([#28788](facebook/react#28788)) //<Ricky>// - **[c771016e1](facebook/react@c771016e1 )**: Rename The Secret Export of Server Internals ([#28786](facebook/react#28786)) //<Sebastian Markbåge>// - **[d50323eb8](facebook/react@d50323eb8 )**: Flatten ReactSharedInternals ([#28783](facebook/react#28783)) //<Sebastian Markbåge>// - **[f62cf8c62](facebook/react@f62cf8c62 )**: [Float] treat `props.async` in Float consistent with the rest of react-dom ([#26760](facebook/react#26760)) //<Josh Story>// - **[dfd3d5af8](facebook/react@dfd3d5af8 )**: Add support for transition{run,start,cancel} events ([#27345](facebook/react#27345)) //<Hugo Sales>// - **[1f8327f83](facebook/react@1f8327f83 )**: [Fiber] Use real event priority for hydration scheduling ([#28765](facebook/react#28765)) //<Josh Story>// - **[97c90ed88](facebook/react@97c90ed88 )**: [DOM] Shrink ReactDOMCurrentDispatcher method names ([#28770](facebook/react#28770)) //<Josh Story>// - **[9007fdc8f](facebook/react@9007fdc8f )**: [DOM] Shrink ReactDOMSharedInternals source representation ([#28771](facebook/react#28771)) //<Josh Story>// - **[14f50ad15](facebook/react@14f50ad15 )**: [Flight] Allow lazily resolving outlined models ([#28780](facebook/react#28780)) //<Sebastian Markbåge>// - **[4c12339ce](facebook/react@4c12339ce )**: [DOM] move `flushSync` out of the reconciler ([#28500](facebook/react#28500)) //<Josh Story>// - **[8e1462e8c](facebook/react@8e1462e8c )**: [Fiber] Move updatePriority tracking to renderers ([#28751](facebook/react#28751)) //<Josh Story>// - **[0b3b8a6a3](facebook/react@0b3b8a6a3 )**: jsx: Remove unnecessary hasOwnProperty check ([#28775](facebook/react#28775)) //<Andrew Clark>// - **[2acfb7b60](facebook/react@2acfb7b60 )**: [Flight] Support FormData from Server to Client ([#28754](facebook/react#28754)) //<Sebastian Markbåge>// - **[d1547defe](facebook/react@d1547defe )**: Fast JSX: Don't clone props object ([#28768](facebook/react#28768)) //<Andrew Clark>// - **[bfd8da807](facebook/react@bfd8da807 )**: Make class prop resolution faster ([#28766](facebook/react#28766)) //<Andrew Clark>// - **[cbb6f2b54](facebook/react@cbb6f2b54 )**: [Flight] Support Blobs from Server to Client ([#28755](facebook/react#28755)) //<Sebastian Markbåge>// - **[f33a6b69c](facebook/react@f33a6b69c )**: Track Owner for Server Components in DEV ([#28753](facebook/react#28753)) //<Sebastian Markbåge>// - **[e3ebcd54b](facebook/react@e3ebcd54b )**: Move string ref coercion to JSX runtime ([#28473](facebook/react#28473)) //<Andrew Clark>// - **[fd0da3eef](facebook/react@fd0da3eef )**: Remove _owner field from JSX elements in prod if string refs are disabled ([#28739](facebook/react#28739)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions 48b4ecc...b5e5ce8 jest_e2e[run_all_tests] bypass-github-export-checks Reviewed By: kassens Differential Revision: D56251607 fbshipit-source-id: e16db2fa101fc7ed1e009158c76388206beabd5f

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 3, 2024

rickhanlonii mentioned this pull request Apr 3, 2024

[tests] add assertConsole<method>Dev helpers #28732

Merged

rickhanlonii force-pushed the rh/flush-act-logs branch from eed73a7 to 6f0080f Compare April 4, 2024 14:14

rickhanlonii requested a review from acdlite April 5, 2024 14:51

acdlite approved these changes Apr 5, 2024

View reviewed changes

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] Fix assertions not flushed before act (#28745)

42eff4b

Fixes some easy cases blocking #28737, I'll follow up with more complex/interesting cases in other PRs.

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] assertLog before act in ReactCompositeComponentState (#28758)

e36ee76

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] assertLog before act in ReactDOMServerSelectiveHydration (#28759

88df524

) Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] assertLog before act in ReactUpdates (#28760)

6e1e2f2

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] assertLog before act in ReactErrorBoundaries (#28761)

b02199d

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] assertLog before act in ReactUse (#28762)

dfc64c6

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] assertLog before act in useEffectEvent (#28763)

2243b40

Fixes tests blocking #28737

rickhanlonii force-pushed the rh/flush-act-logs branch from 6f0080f to a2b6db0 Compare April 10, 2024 14:38

rickhanlonii mentioned this pull request Apr 10, 2024

Remove Scheduler.log from ReactSuspenseFuzz-test #28812

Merged

rickhanlonii force-pushed the rh/flush-act-logs branch from 5747e2b to d4e8f6b Compare April 10, 2024 15:45

rickhanlonii marked this pull request as ready for review April 10, 2024 15:46

rickhanlonii mentioned this pull request Apr 10, 2024

[tests] add assertLog for legacy mode tests #28814

Merged

rickhanlonii added a commit that referenced this pull request Apr 10, 2024

[tests] add assertLog for legacy mode tests (#28814)

870e404

A few more tests for #28737

rickhanlonii added 2 commits April 10, 2024 14:02

[tests] Assert scheduler log empty in internalAct

8d7d68e

Add jest-diff to flow types

66f4133

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactUpdates (#28760)

eba5372

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactErrorBoundaries (#28761)

d623be4

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactUse (#28762)

c0e0606

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in useEffectEvent (#28763)

d3cd412

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] add assertLog for legacy mode tests (#28814)

9d096fb

A few more tests for #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] Fix assertions not flushed before act (#28745)

375820d

Fixes some easy cases blocking #28737, I'll follow up with more complex/interesting cases in other PRs.

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactCompositeComponentState (#28758)

f9fccf9

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactDOMServerSelectiveHydration (#28759

3383b71

) Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactUpdates (#28760)

7ce9a4d

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactErrorBoundaries (#28761)

d74817a

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in ReactUse (#28762)

f9851d2

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] assertLog before act in useEffectEvent (#28763)

ce262b1

Fixes tests blocking #28737

rickhanlonii added a commit that referenced this pull request Apr 11, 2024

[tests] add assertLog for legacy mode tests (#28814)

4af0ae9

A few more tests for #28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] Fix assertions not flushed before act (facebook#28745)

1296b35

Fixes some easy cases blocking facebook#28737, I'll follow up with more complex/interesting cases in other PRs.

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] assertLog before act in ReactCompositeComponentState (faceboo…

d552b27

…k#28758) Fixes tests blocking facebook#28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] assertLog before act in ReactDOMServerSelectiveHydration (fac…

50b41eb

…ebook#28759) Fixes tests blocking facebook#28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] assertLog before act in ReactUpdates (facebook#28760)

84e9db3

Fixes tests blocking facebook#28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] assertLog before act in ReactErrorBoundaries (facebook#28761)

cf6ee16

Fixes tests blocking facebook#28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] assertLog before act in ReactUse (facebook#28762)

e85651b

Fixes tests blocking facebook#28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] assertLog before act in useEffectEvent (facebook#28763)

0471744

Fixes tests blocking facebook#28737

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

[tests] add assertLog for legacy mode tests (facebook#28814)

9cd2d04

A few more tests for facebook#28737

This was referenced Apr 24, 2024

Update React from c3048aab4 to cb151849e1 vercel/next.js#64994

Closed

Support React 19 in App and Pages router vercel/next.js#65058

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests] Assert scheduler log empty in internalAct #28737

[tests] Assert scheduler log empty in internalAct #28737

rickhanlonii commented Apr 3, 2024 •

edited

Loading

react-sizebot commented Apr 3, 2024 •

edited

Loading

[tests] Assert scheduler log empty in internalAct #28737

[tests] Assert scheduler log empty in internalAct #28737

Conversation

rickhanlonii commented Apr 3, 2024 • edited Loading

react-sizebot commented Apr 3, 2024 • edited Loading

Critical size changes

Significant size changes

rickhanlonii commented Apr 3, 2024 •

edited

Loading

react-sizebot commented Apr 3, 2024 •

edited

Loading