Move useMemoCache hook to react/compiler-runtime #28954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
force-pushed
the
pr28954
branch
2 times, most recently
from
290712f
to
7f13ae3
Compare
kassens
force-pushed
the
pr28954
branch
2 times, most recently
from
d7bae39
to
e2aa58f
Compare
kassens
force-pushed
the
pr28954
branch
2 times, most recently
from
7fd1a59
to
50f76da
Compare
kassens
commented
Apr 29, 2024
| @@ -36,7 +36,7 @@ export const disableTextareaChildren = false; | |||
| export const enableSuspenseAvoidThisFallback = false; | |||
| export const enableSuspenseAvoidThisFallbackFizz = false; | |||
| export const enableCPUSuspense = false; | |||
| export const enableUseMemoCacheHook = true; | |||
| export const enableUseMemoCacheHook = __EXPERIMENTAL__; | |||
There was a problem hiding this comment.
This needs to match as a bundle test is using the test renderer and asserting this isn't available in non-experimental.
For Meta-internal purposes, we keep the export on `react` itself to reduce churn.
acdlite
approved these changes
Apr 30, 2024
poteto
reviewed
Apr 30, 2024
|
|
||
| // export to match the name of the OSS function typically exported from | ||
| // react/compiler-runtime | ||
| export {useMemoCache as c} from './src/ReactHooks'; |
There was a problem hiding this comment.
I'm not sure that's possible as useMemoCache adds an extra field to the fiber.
I think what we can look into is how this should look in the server build. We might iterate on that as the server build should probably have a noop use memo cache or not even use the transform.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Move useMemoCache hook to react/compiler-runtime For Meta-internal purposes, we keep the export on `react` itself to reduce churn. DiffTrain build for commit 4508873.
This was referenced May 7, 2024
hoxyq
added a commit
that referenced
this pull request
May 8, 2024
Full list of changes (not a public changelog): * fix[react-devtools/ci]: fix configurations for e2e testing ([hoxyq](https://github.com/hoxyq) in [#29016](#29016)) * feat[react-devtools]: display forget badge for components in profiling session ([hoxyq](https://github.com/hoxyq) in [#29014](#29014)) * fix[react-devtools]: add backwards compat with legacy element type symbol ([hoxyq](https://github.com/hoxyq) in [#28982](#28982)) * Expose "view source" options to Fusebox integration ([motiz88](https://github.com/motiz88) in [#28973](#28973)) * Enable inspected element context menu in Fusebox ([motiz88](https://github.com/motiz88) in [#28972](#28972)) * Check in `frontend.d.ts` for react-devtools-fusebox, include in build output ([motiz88](https://github.com/motiz88) in [#28970](#28970)) * Devtools: Fix build-for-devtools ([eps1lon](https://github.com/eps1lon) in [#28976](#28976)) * Move useMemoCache hook to react/compiler-runtime ([kassens](https://github.com/kassens) in [#28954](#28954)) * warn -> error for Test Renderer deprecation ([acdlite](https://github.com/acdlite) in [#28904](#28904)) * [react-dom] move all client code to `react-dom/client` ([gnoff](https://github.com/gnoff) in [#28271](#28271)) * Rename the react.element symbol to react.transitional.element ([sebmarkbage](https://github.com/sebmarkbage) in [#28813](#28813)) * Rename Forget badge ([jbonta](https://github.com/jbonta) in [#28858](#28858)) * Devtools: Add support for useFormStatus ([eps1lon](https://github.com/eps1lon) in [#28413](#28413))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move useMemoCache hook to react/compiler-runtime
For Meta-internal purposes, we keep the export on
reactitself to reduce churn.