Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Expose "view source" options to Fusebox integration #28973

Merged
merged 1 commit into from
May 7, 2024

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented May 2, 2024

Summary

Exposes the APIs needed by React Native DevTools (Fusebox) to implement the "view element source" and "view attribute source" features.

How did you test this change?

  1. yarn build in react-devtools-fusebox
  2. Copy artifacts to rn-chrome-devtools-frontend
  3. Write some additional glue code to implement viewElementSourceFunction in our CDT fork.
  4. Test the feature manually.
Screen.Recording.2024-05-02.at.16.55.37.mov

@motiz88 motiz88 force-pushed the rdt-fusebox-expose-more-options branch from 2808423 to a574fbc Compare May 2, 2024 15:12
@motiz88 motiz88 requested a review from hoxyq May 2, 2024 16:01
@motiz88 motiz88 marked this pull request as ready for review May 2, 2024 16:01
@motiz88 motiz88 force-pushed the rdt-fusebox-expose-more-options branch from f8c6e2d to 8896806 Compare May 7, 2024 09:39
@motiz88 motiz88 merged commit afe54bf into facebook:main May 7, 2024
38 checks passed
@motiz88 motiz88 deleted the rdt-fusebox-expose-more-options branch May 7, 2024 15:06
hoxyq added a commit that referenced this pull request May 8, 2024
Full list of changes (not a public changelog):
* fix[react-devtools/ci]: fix configurations for e2e testing
([hoxyq](https://github.com/hoxyq) in
[#29016](#29016))
* feat[react-devtools]: display forget badge for components in profiling
session ([hoxyq](https://github.com/hoxyq) in
[#29014](#29014))
* fix[react-devtools]: add backwards compat with legacy element type
symbol ([hoxyq](https://github.com/hoxyq) in
[#28982](#28982))
* Expose "view source" options to Fusebox integration
([motiz88](https://github.com/motiz88) in
[#28973](#28973))
* Enable inspected element context menu in Fusebox
([motiz88](https://github.com/motiz88) in
[#28972](#28972))
* Check in `frontend.d.ts` for react-devtools-fusebox, include in build
output ([motiz88](https://github.com/motiz88) in
[#28970](#28970))
* Devtools: Fix build-for-devtools
([eps1lon](https://github.com/eps1lon) in
[#28976](#28976))
* Move useMemoCache hook to react/compiler-runtime
([kassens](https://github.com/kassens) in
[#28954](#28954))
* warn -> error for Test Renderer deprecation
([acdlite](https://github.com/acdlite) in
[#28904](#28904))
* [react-dom] move all client code to `react-dom/client`
([gnoff](https://github.com/gnoff) in
[#28271](#28271))
* Rename the react.element symbol to react.transitional.element
([sebmarkbage](https://github.com/sebmarkbage) in
[#28813](#28813))
* Rename Forget badge ([jbonta](https://github.com/jbonta) in
[#28858](#28858))
* Devtools: Add support for useFormStatus
([eps1lon](https://github.com/eps1lon) in
[#28413](#28413))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants