Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle config: inline internal hook wrapper #28978

Merged
merged 1 commit into from
May 3, 2024
Merged

Bundle config: inline internal hook wrapper #28978

merged 1 commit into from
May 3, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented May 2, 2024 •
edited
Loading

Bundle config: inline internal hook wrapper

Instead of reading this wrapper from 2 files for "start" and "end" and then string modifying the templates, just inline them like the other wrappers in this file.

Stack created with Sapling. Best reviewed with ReviewStack.

@kassens
Bundle config: inline internal hook wrapper
63faec5 
Instead of reading this wrapper from 2 files for "start" and "end" and then string modifying the templates, just inline them like the other wrappers in this file.
@kassens kassens mentioned this pull request May 2, 2024
Closed
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 2, 2024
@react-sizebot
Copy link

Comparing: 73bcdfb...63faec5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 492.61 kB 492.61 kB = 87.88 kB 87.88 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 498.86 kB 498.86 kB = 88.93 kB 88.93 kB
facebook-www/ReactDOM-prod.classic.js = 591.22 kB 591.22 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 567.44 kB 567.44 kB = 100.36 kB 100.36 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js = 5.85 kB 5.72 kB = 1.88 kB 1.86 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js = 5.85 kB 5.72 kB = 1.88 kB 1.86 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js = 5.85 kB 5.72 kB = 1.88 kB 1.86 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js = 5.80 kB 5.67 kB = 1.86 kB 1.84 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js = 5.80 kB 5.67 kB = 1.86 kB 1.84 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js = 5.80 kB 5.67 kB = 1.86 kB 1.84 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js = 2.77 kB 2.64 kB = 1.25 kB 1.23 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js = 2.77 kB 2.64 kB = 1.25 kB 1.23 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js = 2.77 kB 2.64 kB = 1.25 kB 1.23 kB
oss-experimental/use-subscription/cjs/use-subscription.development.js = 1.51 kB 1.38 kB = 0.66 kB 0.64 kB
oss-stable-semver/use-subscription/cjs/use-subscription.development.js = 1.51 kB 1.38 kB = 0.66 kB 0.64 kB
oss-stable/use-subscription/cjs/use-subscription.development.js = 1.51 kB 1.38 kB = 0.66 kB 0.64 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.development.js = 24.50 kB 24.37 kB = 6.26 kB 6.25 kB
oss-stable/react-dom/cjs/react-dom.development.js = 24.49 kB 24.36 kB = 6.26 kB 6.24 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 24.46 kB 24.33 kB = 6.23 kB 6.22 kB
facebook-www/Scheduler-dev.classic.js = 22.71 kB 22.58 kB = 5.92 kB 5.90 kB
facebook-www/Scheduler-dev.modern.js = 22.71 kB 22.58 kB = 5.92 kB 5.90 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js = 17.21 kB 17.09 kB = 4.86 kB 4.84 kB
oss-experimental/scheduler/cjs/scheduler.development.js = 17.19 kB 17.06 kB = 4.83 kB 4.81 kB
oss-stable-semver/scheduler/cjs/scheduler.development.js = 17.19 kB 17.06 kB = 4.83 kB 4.81 kB
oss-stable/scheduler/cjs/scheduler.development.js = 17.19 kB 17.06 kB = 4.83 kB 4.81 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js = 8.39 kB 8.26 kB = 3.18 kB 3.16 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js = 8.39 kB 8.26 kB = 3.18 kB 3.16 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js = 8.39 kB 8.26 kB = 3.18 kB 3.16 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js = 7.80 kB 7.67 kB = 3.08 kB 3.06 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js = 7.80 kB 7.67 kB = 3.08 kB 3.06 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js = 7.80 kB 7.67 kB = 3.08 kB 3.06 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js = 5.85 kB 5.72 kB = 1.88 kB 1.86 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js = 5.85 kB 5.72 kB = 1.88 kB 1.86 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js = 5.85 kB 5.72 kB = 1.88 kB 1.86 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js = 5.80 kB 5.67 kB = 1.86 kB 1.84 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js = 5.80 kB 5.67 kB = 1.86 kB 1.84 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js = 5.80 kB 5.67 kB = 1.86 kB 1.84 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js = 2.77 kB 2.64 kB = 1.25 kB 1.23 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js = 2.77 kB 2.64 kB = 1.25 kB 1.23 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js = 2.77 kB 2.64 kB = 1.25 kB 1.23 kB
oss-experimental/use-subscription/cjs/use-subscription.development.js = 1.51 kB 1.38 kB = 0.66 kB 0.64 kB
oss-stable-semver/use-subscription/cjs/use-subscription.development.js = 1.51 kB 1.38 kB = 0.66 kB 0.64 kB
oss-stable/use-subscription/cjs/use-subscription.development.js = 1.51 kB 1.38 kB = 0.66 kB 0.64 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 63faec5

rickhanlonii
rickhanlonii approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in the bundle output that there's no impact, it actually just removed a couple unnecessary comments

https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/react/cjs/react.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573

@kassens kassens merged commit 0a0a3af into facebook:main May 3, 2024
38 checks passed
@kassens kassens deleted the pr28978 branch May 3, 2024 18:08
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@kassens
Bundle config: inline internal hook wrapper (#28978)
01110ac 
Bundle config: inline internal hook wrapper

Instead of reading this wrapper from 2 files for "start" and "end" and
then string modifying the templates, just inline them like the other
wrappers in this file.

DiffTrain build for commit 0a0a3af.
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@kassens
Bundle config: inline internal hook wrapper (#28978)
b76cf7b 
Bundle config: inline internal hook wrapper

Instead of reading this wrapper from 2 files for "start" and "end" and
then string modifying the templates, just inline them like the other
wrappers in this file.

DiffTrain build for [0a0a3af](0a0a3af)
@eps1lon eps1lon mentioned this pull request May 16, 2024
Merged
eps1lon added a commit to vercel/next.js that referenced this pull request May 16, 2024
@eps1lon
Update React from 4508873393 to 04b058868c (#65864)
c045f0f 
Completes #65845 which only
updated Canary not Experimental.

<details>
<summary> React upstream changes</summary>

- facebook/react#29026
- facebook/react#29025
- facebook/react#28743
- facebook/react#29022
- facebook/react#29023
- facebook/react#29015
- facebook/react#29016
- facebook/react#28988
- facebook/react#28987
- facebook/react#28986
- facebook/react#29014
- facebook/react#28982
- facebook/react#29006
- facebook/react#28973
- facebook/react#28841
- facebook/react#28964
- facebook/react#28990
- facebook/react#29003
- facebook/react#28989
- facebook/react#28893
- facebook/react#28887
- facebook/react#28807
- facebook/react#28978
- facebook/react#28963
- facebook/react#28972
- facebook/react#28970
- facebook/react#28816
- facebook/react#28977
- facebook/react#28974
- facebook/react#28976
- facebook/react#28975
- facebook/react#28969
- facebook/react#28966
- facebook/react#28056

</details>
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
@eps1lon @panteliselef
Update React from 4508873393 to 04b058868c (vercel#65864)
1539871 
Completes vercel#65845 which only
updated Canary not Experimental.

<details>
<summary> React upstream changes</summary>

- facebook/react#29026
- facebook/react#29025
- facebook/react#28743
- facebook/react#29022
- facebook/react#29023
- facebook/react#29015
- facebook/react#29016
- facebook/react#28988
- facebook/react#28987
- facebook/react#28986
- facebook/react#29014
- facebook/react#28982
- facebook/react#29006
- facebook/react#28973
- facebook/react#28841
- facebook/react#28964
- facebook/react#28990
- facebook/react#29003
- facebook/react#28989
- facebook/react#28893
- facebook/react#28887
- facebook/react#28807
- facebook/react#28978
- facebook/react#28963
- facebook/react#28972
- facebook/react#28970
- facebook/react#28816
- facebook/react#28977
- facebook/react#28974
- facebook/react#28976
- facebook/react#28975
- facebook/react#28969
- facebook/react#28966
- facebook/react#28056

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@yungsters yungsters Awaiting requested review from yungsters

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @rickhanlonii @facebook-github-bot