-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toggle consoleManagedByDevToolsDuringStrictMode flag for native #29887
toggle consoleManagedByDevToolsDuringStrictMode flag for native #29887
Conversation
…ssing it to original console
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: f5af92d...7fba323 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
66c8219
to
552267b
Compare
552267b
to
7fba323
Compare
@yungsters Could you please help me clarifying something?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Looks like this flag was enabled for OSS renderers, and we still rely on gk for internal one. Then I would change the approach, we can gradually roll out the internal gk, and then move the flag from the list of dynamic ones to the static, with a default value of cc @yungsters Is my thinking correct? |
Yes, that is correct. Thanks, @hoxyq. |
|
Summary
Stacked on #29873, please review only the last commit.
The stack
This enables
consoleManagedByDevToolsDuringStrictMode
flag for native.Caution
Only land this and sync the renderers for Native once React DevTools backend version is updated.