Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native-fb] set consoleManagedByDevToolsDuringStrictMode flag to true #30338

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[native-fb] set consoleManagedByDevToolsDuringStrictMode flag to true #30338

merged 1 commit into from
Jul 15, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Jul 15, 2024

Reflecting D59232098.

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 4:26pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 15, 2024
hoxyq
hoxyq approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@hoxyq hoxyq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will close #29887 then, here is the commit with my change

@hoxyq
Copy link
Contributor

hoxyq commented Jul 15, 2024 •
edited
Loading

I think you can enable it by default everywhere for RN (both OSS and FB), we probably still want to keep it for testing environments

@kassens
Copy link
Member Author

kassens commented Jul 15, 2024

I'll leave the external change for a different PR.

@kassens kassens merged commit fc1371f into facebook:main Jul 15, 2024
184 of 185 checks passed
@kassens kassens deleted the pr30338 branch July 15, 2024 16:31
github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
@kassens
[native-fb] set consoleManagedByDevToolsDuringStrictMode flag to true (…
7d4aaba 
…#30338)

Reflecting D59232098.

DiffTrain build for commit fc1371f.
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
@felixshiftellecon
[native-fb] set consoleManagedByDevToolsDuringStrictMode flag to true (…
2ab1ab4 
…facebook#30338)

Reflecting D59232098.
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
@felixshiftellecon
[native-fb] set consoleManagedByDevToolsDuringStrictMode flag to true (…
03ecbdf 
…facebook#30338)

Reflecting D59232098.
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq hoxyq approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kassens @hoxyq @facebook-github-bot