Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow configs creation for crlf systems #30707

Closed
wants to merge 1 commit into from

Conversation

vordgi
Copy link

@vordgi vordgi commented Aug 15, 2024

Summary

The error appears in CRLF systems because the end of the line is \r\n instead of just \n. In this case, the line in CRLF is %CI_MAX_WORKERS%\r\n, and therefore the condition %CI_MAX_WORKERS%\n for this line isn't met.

Rewrote the replace rule with a regular expression that allows an optional \r (\r?) before \n.

Fixes #27691

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:55pm

@react-sizebot
Copy link

react-sizebot commented Aug 19, 2024

Comparing: a960b92...87f2c9b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7bf39f6

@poteto
Copy link
Member

poteto commented Aug 20, 2024

I think we can remove this altogether: #30753

poteto added a commit that referenced this pull request Aug 20, 2024
Noticed this from #30707. This was vestigial from from circleci and now
that we're on GH actions I think we should be able to remove this option
altogether.

ghstack-source-id: 78e8b0243b1e1484ffaad820987ae3679a7374bf
Pull Request resolved: #30753
poteto added a commit that referenced this pull request Aug 20, 2024
Noticed this from #30707. This was vestigial from from circleci and now
that we're on GH actions I think we should be able to remove this option
altogether.

ghstack-source-id: 78e8b0243b1e1484ffaad820987ae3679a7374bf
Pull Request resolved: #30753
@vordgi
Copy link
Author

vordgi commented Aug 20, 2024

No longer relevant after merge #30753

Thanks @poteto!

@vordgi vordgi closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to parse line in .flowconfig file
4 participants