Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow] Remove CI_MAX_WORKERS option #30753

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

poteto
Copy link
Member

@poteto poteto commented Aug 20, 2024

Stack from ghstack (oldest at bottom):

Noticed this from #30707. This was vestigial from from circleci and now
that we're on GH actions I think we should be able to remove this option
altogether.

[ghstack-poisoned]
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 3:02pm

poteto added a commit that referenced this pull request Aug 20, 2024
This was vestigial from from circleci fand now that we're on GH actions
I think we should be able to remove this.

ghstack-source-id: 78e8b0243b1e1484ffaad820987ae3679a7374bf
Pull Request resolved: #30753
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 20, 2024
poteto added a commit that referenced this pull request Aug 20, 2024
This was vestigial from from circleci and now that we're on GH actions
I think we should be able to remove this altogether.

ghstack-source-id: 78e8b0243b1e1484ffaad820987ae3679a7374bf
Pull Request resolved: #30753
@react-sizebot
Copy link

Comparing: a960b92...2c8654d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 21782c8

poteto added a commit that referenced this pull request Aug 20, 2024
Noticed this from #30707. This was vestigial from from circleci and now
that we're on GH actions I think we should be able to remove this option
altogether.

ghstack-source-id: 78e8b0243b1e1484ffaad820987ae3679a7374bf
Pull Request resolved: #30753
@poteto poteto merged commit 21782c8 into gh/poteto/4/base Aug 20, 2024
185 checks passed
poteto added a commit that referenced this pull request Aug 20, 2024
Noticed this from #30707. This was vestigial from from circleci and now
that we're on GH actions I think we should be able to remove this option
altogether.

ghstack-source-id: 78e8b0243b1e1484ffaad820987ae3679a7374bf
Pull Request resolved: #30753
@poteto poteto deleted the gh/poteto/4/head branch August 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants