Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove turbopack unbundled/register/loader #30756

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sebmarkbage
Copy link
Collaborator

The unbundled form is just a way to show case a prototype for how an unbundled version of RSC can work. It's not really intended for every bundler combination to provide such a configuration.

There's no configuration of Turbopack that supports this mode atm and possibly never will be since it's more of an integrated server/client experience.

This removes the unbundled form and node register/loaders from the turbopack build.

@sebmarkbage sebmarkbage requested a review from gnoff August 20, 2024 19:51
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 7:53pm

@react-sizebot
Copy link

Comparing: 92d26c8...6eaeb35

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 94.44 kB 0.00 kB Deleted 18.21 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 53.08 kB 0.00 kB Deleted 10.95 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 154.19 kB 0.00 kB Deleted 27.94 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 101.21 kB 0.00 kB Deleted 20.32 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 86.52 kB 0.00 kB Deleted 16.58 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 52.57 kB 0.00 kB Deleted 10.89 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 134.67 kB 0.00 kB Deleted 24.80 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 94.08 kB 0.00 kB Deleted 19.23 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 86.52 kB 0.00 kB Deleted 16.58 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 52.57 kB 0.00 kB Deleted 10.89 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 134.67 kB 0.00 kB Deleted 24.80 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 94.08 kB 0.00 kB Deleted 19.23 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 86.52 kB 0.00 kB Deleted 16.58 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 52.57 kB 0.00 kB Deleted 10.89 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 134.67 kB 0.00 kB Deleted 24.80 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 94.08 kB 0.00 kB Deleted 19.23 kB 0.00 kB
oss-stable/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-stable/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-stable/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-stable/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 94.44 kB 0.00 kB Deleted 18.21 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 53.08 kB 0.00 kB Deleted 10.95 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 154.19 kB 0.00 kB Deleted 27.94 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 101.21 kB 0.00 kB Deleted 20.32 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-experimental/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 86.52 kB 0.00 kB Deleted 16.58 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 52.57 kB 0.00 kB Deleted 10.89 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 134.67 kB 0.00 kB Deleted 24.80 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 94.08 kB 0.00 kB Deleted 19.23 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-stable-rc/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 86.52 kB 0.00 kB Deleted 16.58 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 52.57 kB 0.00 kB Deleted 10.89 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 134.67 kB 0.00 kB Deleted 24.80 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 94.08 kB 0.00 kB Deleted 19.23 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-stable-semver/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js Deleted 86.52 kB 0.00 kB Deleted 16.58 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js Deleted 52.57 kB 0.00 kB Deleted 10.89 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-node-register.js Deleted 2.35 kB 0.00 kB Deleted 0.91 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js Deleted 134.67 kB 0.00 kB Deleted 24.80 kB 0.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js Deleted 94.08 kB 0.00 kB Deleted 19.23 kB 0.00 kB
oss-stable/react-server-dom-turbopack/client.node.unbundled.js Deleted 0.27 kB 0.00 kB Deleted 0.17 kB 0.00 kB
oss-stable/react-server-dom-turbopack/esm/react-server-dom-turbopack-node-loader.production.js Deleted 12.54 kB 0.00 kB Deleted 3.09 kB 0.00 kB
oss-stable/react-server-dom-turbopack/node-register.js Deleted 0.09 kB 0.00 kB Deleted 0.10 kB 0.00 kB
oss-stable/react-server-dom-turbopack/server.node.unbundled.js Deleted 0.74 kB 0.00 kB Deleted 0.30 kB 0.00 kB
oss-stable/react-server-dom-turbopack/static.node.unbundled.js Deleted 0.35 kB 0.00 kB Deleted 0.20 kB 0.00 kB

Generated by 🚫 dangerJS against 96dc143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants