Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused field _debugIsCurrentlyTiming #31753

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove unused field _debugIsCurrentlyTiming #31753

merged 1 commit into from
Dec 13, 2024
+0 −1

Conversation

sebmarkbage
Copy link
Collaborator

This field is unused. It's not there at runtime. It's just legacy from the type.

@sebmarkbage sebmarkbage requested a review from acdlite December 13, 2024 04:49
@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:50am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@react-sizebot
Copy link

Comparing: d5e8f79...18bd0c4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.72 kB 510.72 kB = 91.37 kB 91.37 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.63 kB 515.63 kB = 92.07 kB 92.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.55 kB 595.55 kB = 105.06 kB 105.06 kB
facebook-www/ReactDOM-prod.modern.js = 585.82 kB 585.82 kB = 103.49 kB 103.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 77b5663

@sebmarkbage sebmarkbage merged commit 56ae4b8 into facebook:main Dec 13, 2024
187 checks passed
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 13, 2024
@pull
Remove unused field _debugIsCurrentlyTiming (facebook#31753)
a5106bb 
This field is unused. It's not there at runtime. It's just legacy from
the type.

DiffTrain build for [56ae4b8](facebook@56ae4b8)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 13, 2024
@pull
Remove unused field _debugIsCurrentlyTiming (facebook#31753)
dcc27d7 
This field is unused. It's not there at runtime. It's just legacy from
the type.

DiffTrain build for [56ae4b8](facebook@56ae4b8)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @react-sizebot @facebook-github-bot